[jira] [Commented] (KAFKA-5890) records.lag should use tags for topic and partition rather than using metric name.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304856#comment-16304856 ] 

ASF GitHub Bot commented on KAFKA-5890:
---------------------------------------

lahabana opened a new pull request #4362: KAFKA-5890 records.lag should use tags for topic and partition rather than using metric name.
URL: https://github.com/apache/kafka/pull/4362
 
 
   This is the implementation of KIP-225.
   It marks the previous metrics as deprecated in the documentation and adds new metrics using tags.
   
   Testing verifies that both the new and the old metric report the same value.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> records.lag should use tags for topic and partition rather than using metric name.
> ----------------------------------------------------------------------------------
>
>                 Key: KAFKA-5890
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5890
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients
>    Affects Versions: 0.10.2.0
>            Reporter: Charly Molter
>
> As part of KIP-92[1] a per partition lag metric was added.
> These metrics are really useful, however in the implementation  it was implemented as a prefix to the metric name: https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java#L1321-L1344
> Usually these kind of metrics use tags and the name is constant for all topics, partitions.
> We have a custom reporter which aggregates topics/partitions together to avoid explosion of the number of KPIs and this KPI doesn't support this as it doesn't have tags but a complex name.
> [1] https://cwiki.apache.org/confluence/display/KAFKA/KIP-92+-+Add+per+partition+lag+metrics+to+KafkaConsumer



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)