You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by DivineEnder <gi...@git.apache.org> on 2017/07/28 17:58:14 UTC

[GitHub] geode pull request #666: GEODE-3329: Changed logging output of modify_war sc...

GitHub user DivineEnder opened a pull request:

    https://github.com/apache/geode/pull/666

    GEODE-3329: Changed logging output of modify_war script

    Changed the modify_war script so that its output and error streams write to a log file instead of to standard out.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DivineEnder/geode feature/GEODE-3329

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #666
    
----
commit 0fb270a5916d32e00847b48a7fd9de2bc2b566af
Author: David Anuta <da...@gmail.com>
Date:   2017-07-28T17:49:36Z

    GEODE-3329: Changed logging output of modify_war script
    
    Changed the modify_war script so that its output and error streams write to a log file instead of to standard out.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #666: GEODE-3329: Changed logging output of modify_war sc...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/666


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #666: GEODE-3329: Changed logging output of modify_war script

Posted by DivineEnder <gi...@git.apache.org>.
Github user DivineEnder commented on the issue:

    https://github.com/apache/geode/pull/666
  
    @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou @PurelyApplied


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #666: GEODE-3329: Changed logging output of modify_war script

Posted by PurelyApplied <gi...@git.apache.org>.
Github user PurelyApplied commented on the issue:

    https://github.com/apache/geode/pull/666
  
    Thanks for the quick turn around on this!  +0.5, since I don't really know this corner of the code, but it looks good to me!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---