[GitHub] [opennlp-sandbox] kinow commented on pull request #76: Update sandbox component 'summarizer' to be compatible with latest opennlp-tools release

["kinow (via GitHub)" <gi...@apache.org>]

kinow commented on PR #76:
URL: https://github.com/apache/opennlp-sandbox/pull/76#issuecomment-1407476623

   Hi @mawiesne 
   
   >@kinow & @rzo1 - Please check src/test/resources/wordnet
   >Sadly, all WordNet dict files are required during execution of tests. If not present, some tests will fail. Local folders are no option, it seems to me, when we strive for CI / GH actions.
   >
   >I'm interested to have your opinion / feedback for this resource.
   
   Just checked, WordNet is 11MB compressed, and ~40MB decompressed :thinking:
   
   For the past 3 months I've been jumping between hotels & airbnb's in Barcelona, and I can tell I got both excellent and really slow Internet reception from mobile&wifi, and running Docker and Maven was not a good experience for some projects. Given we have multiple components in `opennlp-sandbox`, if we start to get many of these 10+ MB files it'd be easy to reach close to 100MB of files for tests, I think.
   
   I think @rzo1 's suggestion of pulling that file when running the tests is probably the best option.
   
   >Do you mean because of the size of Wordnet, its presence in git or its license?
   
   Not sure if the WordNet/Princeton license is compatible with ASF. I had a look and it looks OK to me, but IANAL and haven't had to use these two licenses before - https://wordnet.princeton.edu/license-and-commercial-use. Still, probably confirming it too.
   
   Cheers


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: devnull-unsubscribe@infra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org