[GitHub] [drill] paul-rogers commented on a change in pull request #2424: DRILL-8092: Add Auto Pagination to HTTP Storage Plugin

[GitBox <gi...@apache.org>]

paul-rogers commented on a change in pull request #2424:
URL: https://github.com/apache/drill/pull/2424#discussion_r780724393



##########
File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/paginator/PagePaginator.java
##########
@@ -64,16 +60,16 @@ public PagePaginator(Builder builder, int limit, int pageSize, String pageParam,
   }
 
   @Override
-  public String next() {
-    if (hasLimit) {
-      return super.next();
-    } else {
-      return generateNextUrl();
-    }
+  public boolean hasNext() {
+    return !partialPageReceived && (limit < 0 || (currentPage-1) * pageSize < limit);

Review comment:
       Limit code is off. A limit of 0 should be allowed: it means schema only. Fixed in the EVF V2/Easy Format Plugin PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org