You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2021/04/21 07:42:12 UTC
[GitHub] [incubator-tuweni] atoulme opened a new pull request #209: add crawler
atoulme opened a new pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
## PR description
Adds a crawler recording all nodes it meets on an Ethereum network from a few bootnodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme commented on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
atoulme commented on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824292565
😓 will fix...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824539673
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#209](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3660c2f) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e68c5a) will **decrease** coverage by `4.76%`.
> The diff coverage is `35.48%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #209 +/- ##
============================================
- Coverage 65.52% 60.76% -4.77%
+ Complexity 4300 3991 -309
============================================
Files 401 379 -22
Lines 21435 21203 -232
Branches 2812 2820 +8
============================================
- Hits 14046 12883 -1163
- Misses 5823 6870 +1047
+ Partials 1566 1450 -116
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.76% <35.48%> (-0.16%)` | `3991.00 <4.00> (+3.00)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `47.29% <0.00%> (-2.59%)` | `0.00 <0.00> (ø)` | |
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/tuweni/ethclient/DiscoveryPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0Rpc2NvdmVyeVBlZXJSZXBvc2l0b3J5Lmt0) | `37.50% <0.00%> (-1.64%)` | `4.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/eth/crawler/CrawlerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJBcHAua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lin/org/apache/tuweni/eth/crawler/CrawlerConfig.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJDb25maWcua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...java/org/apache/tuweni/concurrent/ExpiringSet.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvRXhwaXJpbmdTZXQuamF2YQ==) | `45.71% <16.66%> (ø)` | `19.00 <0.00> (ø)` | |
| [...che/tuweni/eth/crawler/RelationalPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL1JlbGF0aW9uYWxQZWVyUmVwb3NpdG9yeS5rdA==) | `64.36% <64.36%> (ø)` | `4.00 <4.00> (?)` | |
| [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `73.46% <69.23%> (+0.96%)` | `0.00 <0.00> (ø)` | |
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [84 more](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e68c5a...3660c2f](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824539673
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#209](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a00ae2) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e68c5a) will **decrease** coverage by `0.48%`.
> The diff coverage is `23.59%`.
> :exclamation: Current head 9a00ae2 differs from pull request most recent head a02840e. Consider uploading reports for the commit a02840e to get more accurate results
[](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #209 +/- ##
============================================
- Coverage 65.52% 65.04% -0.49%
- Complexity 4300 4301 +1
============================================
Files 401 408 +7
Lines 21435 21682 +247
Branches 2812 2836 +24
============================================
+ Hits 14046 14103 +57
- Misses 5823 6007 +184
- Partials 1566 1572 +6
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `47.61% <11.49%> (+0.57%)` | `641.00 <0.00> (+4.00)` | |
| unit | `60.52% <23.23%> (-0.39%)` | `3992.00 <4.00> (+4.00)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lin/org/apache/tuweni/devp2p/eth/EthHelloClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NsaWVudC5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/devp2p/eth/EthHelloController.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NvbnRyb2xsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...in/org/apache/tuweni/devp2p/eth/EthHelloHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0hhbmRsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/tuweni/devp2p/eth/EthHelloSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb1N1YnByb3RvY29sLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/tuweni/ethclient/DiscoveryPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0Rpc2NvdmVyeVBlZXJSZXBvc2l0b3J5Lmt0) | `37.50% <0.00%> (-1.64%)` | `4.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/eth/crawler/CrawlerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJBcHAua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lin/org/apache/tuweni/eth/crawler/CrawlerConfig.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJDb25maWcua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...n/java/org/apache/tuweni/rlpx/wire/Capability.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9DYXBhYmlsaXR5LmphdmE=) | `50.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...java/org/apache/tuweni/concurrent/ExpiringSet.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvRXhwaXJpbmdTZXQuamF2YQ==) | `45.71% <16.66%> (ø)` | `19.00 <0.00> (ø)` | |
| ... and [18 more](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e68c5a...a02840e](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] nfmelendez commented on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
nfmelendez commented on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824150960
also
'eth-crawler/src/main/resources/db/migration/V1_1_0__create_db.sql'
to ignore in rat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824539673
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#209](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a00ae2) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e68c5a) will **decrease** coverage by `5.00%`.
> The diff coverage is `23.23%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #209 +/- ##
============================================
- Coverage 65.52% 60.52% -5.01%
+ Complexity 4300 3992 -308
============================================
Files 401 383 -18
Lines 21435 21301 -134
Branches 2812 2829 +17
============================================
- Hits 14046 12893 -1153
- Misses 5823 6959 +1136
+ Partials 1566 1449 -117
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.52% <23.23%> (-0.39%)` | `3992.00 <4.00> (+4.00)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lin/org/apache/tuweni/devp2p/eth/EthHelloClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NsaWVudC5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/devp2p/eth/EthHelloController.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NvbnRyb2xsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...in/org/apache/tuweni/devp2p/eth/EthHelloHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0hhbmRsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/tuweni/devp2p/eth/EthHelloSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb1N1YnByb3RvY29sLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `47.29% <0.00%> (-2.59%)` | `0.00 <0.00> (ø)` | |
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/tuweni/ethclient/DiscoveryPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0Rpc2NvdmVyeVBlZXJSZXBvc2l0b3J5Lmt0) | `37.50% <0.00%> (-1.64%)` | `4.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/eth/crawler/CrawlerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJBcHAua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lin/org/apache/tuweni/eth/crawler/CrawlerConfig.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJDb25maWcua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...n/java/org/apache/tuweni/rlpx/wire/Capability.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9DYXBhYmlsaXR5LmphdmE=) | `42.85% <ø> (-7.15%)` | `3.00 <0.00> (-1.00)` | |
| ... and [92 more](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e68c5a...9a00ae2](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824539673
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#209](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb0d36e) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e68c5a) will **decrease** coverage by `0.42%`.
> The diff coverage is `23.59%`.
> :exclamation: Current head cb0d36e differs from pull request most recent head 9a00ae2. Consider uploading reports for the commit 9a00ae2 to get more accurate results
[](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #209 +/- ##
============================================
- Coverage 65.52% 65.10% -0.43%
- Complexity 4300 4306 +6
============================================
Files 401 408 +7
Lines 21435 21682 +247
Branches 2812 2836 +24
============================================
+ Hits 14046 14116 +70
- Misses 5823 5993 +170
- Partials 1566 1573 +7
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `47.96% <11.49%> (+0.92%)` | `648.00 <0.00> (+11.00)` | |
| unit | `60.49% <23.23%> (-0.43%)` | `3992.00 <4.00> (+4.00)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lin/org/apache/tuweni/devp2p/eth/EthHelloClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NsaWVudC5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/devp2p/eth/EthHelloController.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NvbnRyb2xsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...in/org/apache/tuweni/devp2p/eth/EthHelloHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0hhbmRsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/tuweni/devp2p/eth/EthHelloSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb1N1YnByb3RvY29sLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/tuweni/ethclient/DiscoveryPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0Rpc2NvdmVyeVBlZXJSZXBvc2l0b3J5Lmt0) | `37.50% <0.00%> (-1.64%)` | `4.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/eth/crawler/CrawlerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJBcHAua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lin/org/apache/tuweni/eth/crawler/CrawlerConfig.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJDb25maWcua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...n/java/org/apache/tuweni/rlpx/wire/Capability.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9DYXBhYmlsaXR5LmphdmE=) | `50.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...java/org/apache/tuweni/concurrent/ExpiringSet.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvRXhwaXJpbmdTZXQuamF2YQ==) | `45.71% <16.66%> (ø)` | `19.00 <0.00> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e68c5a...9a00ae2](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824539673
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#209](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3660c2f) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e68c5a) will **decrease** coverage by `0.21%`.
> The diff coverage is `36.02%`.
> :exclamation: Current head 3660c2f differs from pull request most recent head cb0d36e. Consider uploading reports for the commit cb0d36e to get more accurate results
[](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #209 +/- ##
============================================
- Coverage 65.52% 65.31% -0.22%
Complexity 4300 4300
============================================
Files 401 404 +3
Lines 21435 21584 +149
Branches 2812 2827 +15
============================================
+ Hits 14046 14098 +52
- Misses 5823 5915 +92
- Partials 1566 1571 +5
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `46.90% <28.57%> (-0.15%)` | `629.00 <0.00> (-8.00)` | |
| unit | `60.76% <35.48%> (-0.16%)` | `3991.00 <4.00> (+3.00)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/tuweni/ethclient/DiscoveryPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0Rpc2NvdmVyeVBlZXJSZXBvc2l0b3J5Lmt0) | `37.50% <0.00%> (-1.64%)` | `4.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/eth/crawler/CrawlerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJBcHAua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lin/org/apache/tuweni/eth/crawler/CrawlerConfig.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJDb25maWcua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...java/org/apache/tuweni/concurrent/ExpiringSet.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvRXhwaXJpbmdTZXQuamF2YQ==) | `45.71% <16.66%> (ø)` | `19.00 <0.00> (ø)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `50.11% <50.00%> (+0.23%)` | `0.00 <0.00> (ø)` | |
| [...che/tuweni/eth/crawler/RelationalPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL1JlbGF0aW9uYWxQZWVyUmVwb3NpdG9yeS5rdA==) | `64.36% <64.36%> (ø)` | `4.00 <4.00> (?)` | |
| [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `73.46% <69.23%> (+0.96%)` | `0.00 <0.00> (ø)` | |
| [...ain/kotlin/org/apache/tuweni/relayer/RelayerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aG9iYml0cy1yZWxheWVyL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9yZWxheWVyL1JlbGF5ZXJBcHAua3Q=) | `58.82% <0.00%> (-11.77%)` | `1.00% <0.00%> (-1.00%)` | |
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `64.28% <0.00%> (-5.36%)` | `0.00% <0.00%> (ø%)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e68c5a...cb0d36e](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824539673
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#209](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb0d36e) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e68c5a) will **decrease** coverage by `0.42%`.
> The diff coverage is `23.59%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #209 +/- ##
============================================
- Coverage 65.52% 65.10% -0.43%
- Complexity 4300 4306 +6
============================================
Files 401 408 +7
Lines 21435 21682 +247
Branches 2812 2836 +24
============================================
+ Hits 14046 14116 +70
- Misses 5823 5993 +170
- Partials 1566 1573 +7
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `47.96% <11.49%> (+0.92%)` | `648.00 <0.00> (+11.00)` | |
| unit | `60.49% <23.23%> (-0.43%)` | `3992.00 <4.00> (+4.00)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lin/org/apache/tuweni/devp2p/eth/EthHelloClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NsaWVudC5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/devp2p/eth/EthHelloController.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NvbnRyb2xsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...in/org/apache/tuweni/devp2p/eth/EthHelloHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0hhbmRsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/tuweni/devp2p/eth/EthHelloSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb1N1YnByb3RvY29sLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/tuweni/ethclient/DiscoveryPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0Rpc2NvdmVyeVBlZXJSZXBvc2l0b3J5Lmt0) | `37.50% <0.00%> (-1.64%)` | `4.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/eth/crawler/CrawlerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJBcHAua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lin/org/apache/tuweni/eth/crawler/CrawlerConfig.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJDb25maWcua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...n/java/org/apache/tuweni/rlpx/wire/Capability.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9DYXBhYmlsaXR5LmphdmE=) | `50.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...java/org/apache/tuweni/concurrent/ExpiringSet.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvRXhwaXJpbmdTZXQuamF2YQ==) | `45.71% <16.66%> (ø)` | `19.00 <0.00> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e68c5a...cb0d36e](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme merged pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824539673
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#209](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a02840e) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e68c5a) will **decrease** coverage by `5.26%`.
> The diff coverage is `24.02%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #209 +/- ##
============================================
- Coverage 65.52% 60.26% -5.27%
+ Complexity 4300 4003 -297
============================================
Files 401 385 -16
Lines 21435 21451 +16
Branches 2812 2860 +48
============================================
- Hits 14046 12928 -1118
- Misses 5823 7070 +1247
+ Partials 1566 1453 -113
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.26% <24.02%> (-0.65%)` | `4003.00 <15.00> (+15.00)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lin/org/apache/tuweni/devp2p/eth/EthHelloClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NsaWVudC5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/devp2p/eth/EthHelloController.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NvbnRyb2xsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...in/org/apache/tuweni/devp2p/eth/EthHelloHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0hhbmRsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/tuweni/devp2p/eth/EthHelloSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb1N1YnByb3RvY29sLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/tuweni/ethclient/DiscoveryPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0Rpc2NvdmVyeVBlZXJSZXBvc2l0b3J5Lmt0) | `37.50% <0.00%> (-1.64%)` | `4.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/eth/crawler/CrawlerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJBcHAua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lin/org/apache/tuweni/eth/crawler/CrawlerConfig.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJDb25maWcua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/eth/crawler/rest/PeersService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL3Jlc3QvUGVlcnNTZXJ2aWNlLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...n/java/org/apache/tuweni/rlpx/wire/Capability.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9DYXBhYmlsaXR5LmphdmE=) | `42.85% <ø> (-7.15%)` | `3.00 <0.00> (-1.00)` | |
| ... and [96 more](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e68c5a...a02840e](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] nfmelendez commented on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
nfmelendez commented on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824126220
when build locally it tells me:
Task :eth-client:compileKotlin FAILED
$tuweni/eth-client/src/main/kotlin/org/apache/tuweni/ethclient/DiscoveryPeerRepository.kt: (32, 1): Class 'DiscoveryPeerRepository' is not abstract and does not implement abstract member public abstract fun addListener(listener: (Peer) -> Unit): Unit defined in org.apache.tuweni.devp2p.PeerRepository
Seems a change of an interface wans't implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] nfmelendez commented on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
nfmelendez commented on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824304856
there are 2 peer repositores:
org.apache.tuweni.peer.repository.PeerRepository
org.apache.tuweni.devp2p.PeerRepository
but org.apache.tuweni.peer.repository.PeerRepository doesn't have the method addListener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824539673
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#209](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3660c2f) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e68c5a) will **decrease** coverage by `0.21%`.
> The diff coverage is `36.02%`.
> :exclamation: Current head 3660c2f differs from pull request most recent head 8470db3. Consider uploading reports for the commit 8470db3 to get more accurate results
[](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #209 +/- ##
============================================
- Coverage 65.52% 65.31% -0.22%
Complexity 4300 4300
============================================
Files 401 404 +3
Lines 21435 21584 +149
Branches 2812 2827 +15
============================================
+ Hits 14046 14098 +52
- Misses 5823 5915 +92
- Partials 1566 1571 +5
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `46.90% <28.57%> (-0.15%)` | `629.00 <0.00> (-8.00)` | |
| unit | `60.76% <35.48%> (-0.16%)` | `3991.00 <4.00> (+3.00)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/tuweni/ethclient/DiscoveryPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0Rpc2NvdmVyeVBlZXJSZXBvc2l0b3J5Lmt0) | `37.50% <0.00%> (-1.64%)` | `4.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/eth/crawler/CrawlerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJBcHAua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lin/org/apache/tuweni/eth/crawler/CrawlerConfig.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJDb25maWcua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...java/org/apache/tuweni/concurrent/ExpiringSet.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvRXhwaXJpbmdTZXQuamF2YQ==) | `45.71% <16.66%> (ø)` | `19.00 <0.00> (ø)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `50.11% <50.00%> (+0.23%)` | `0.00 <0.00> (ø)` | |
| [...che/tuweni/eth/crawler/RelationalPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL1JlbGF0aW9uYWxQZWVyUmVwb3NpdG9yeS5rdA==) | `64.36% <64.36%> (ø)` | `4.00 <4.00> (?)` | |
| [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `73.46% <69.23%> (+0.96%)` | `0.00 <0.00> (ø)` | |
| [...ain/kotlin/org/apache/tuweni/relayer/RelayerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aG9iYml0cy1yZWxheWVyL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9yZWxheWVyL1JlbGF5ZXJBcHAua3Q=) | `58.82% <0.00%> (-11.77%)` | `1.00% <0.00%> (-1.00%)` | |
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `64.28% <0.00%> (-5.36%)` | `0.00% <0.00%> (ø%)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e68c5a...8470db3](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824539673
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#209](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a00ae2) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e68c5a) will **decrease** coverage by `0.48%`.
> The diff coverage is `23.59%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #209 +/- ##
============================================
- Coverage 65.52% 65.04% -0.49%
- Complexity 4300 4301 +1
============================================
Files 401 408 +7
Lines 21435 21682 +247
Branches 2812 2836 +24
============================================
+ Hits 14046 14103 +57
- Misses 5823 6007 +184
- Partials 1566 1572 +6
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `47.61% <11.49%> (+0.57%)` | `641.00 <0.00> (+4.00)` | |
| unit | `60.52% <23.23%> (-0.39%)` | `3992.00 <4.00> (+4.00)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lin/org/apache/tuweni/devp2p/eth/EthHelloClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NsaWVudC5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/devp2p/eth/EthHelloController.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NvbnRyb2xsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...in/org/apache/tuweni/devp2p/eth/EthHelloHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0hhbmRsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/tuweni/devp2p/eth/EthHelloSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb1N1YnByb3RvY29sLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/tuweni/ethclient/DiscoveryPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0Rpc2NvdmVyeVBlZXJSZXBvc2l0b3J5Lmt0) | `37.50% <0.00%> (-1.64%)` | `4.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/eth/crawler/CrawlerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJBcHAua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lin/org/apache/tuweni/eth/crawler/CrawlerConfig.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJDb25maWcua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...n/java/org/apache/tuweni/rlpx/wire/Capability.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9DYXBhYmlsaXR5LmphdmE=) | `50.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...java/org/apache/tuweni/concurrent/ExpiringSet.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvRXhwaXJpbmdTZXQuamF2YQ==) | `45.71% <16.66%> (ø)` | `19.00 <0.00> (ø)` | |
| ... and [18 more](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e68c5a...9a00ae2](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] nfmelendez commented on a change in pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
nfmelendez commented on a change in pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#discussion_r617846496
##########
File path: eth-crawler/src/main/kotlin/org/apache/tuweni/eth/crawler/RelationalPeerRepository.kt
##########
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tuweni.eth.crawler
+
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
+import org.apache.tuweni.bytes.Bytes
+import org.apache.tuweni.concurrent.AsyncResult
+import org.apache.tuweni.concurrent.coroutines.asyncResult
+import org.apache.tuweni.crypto.SECP256K1
+import org.apache.tuweni.devp2p.Endpoint
+import org.apache.tuweni.devp2p.EthereumNodeRecord
+import org.apache.tuweni.devp2p.Peer
+import org.apache.tuweni.devp2p.PeerRepository
+import org.apache.tuweni.devp2p.parseEnodeUri
+import java.net.URI
+import java.sql.Timestamp
+import java.util.UUID
+import javax.sql.DataSource
+import kotlin.coroutines.CoroutineContext
+
+class RelationalPeerRepository(
+ private val dataSource: DataSource,
+ override val coroutineContext: CoroutineContext = Dispatchers.Default,
+) : CoroutineScope, PeerRepository {
+
+ private val listeners = mutableListOf<(Peer) -> Unit>()
+
+ override fun addListener(listener: (Peer) -> Unit) {
+ listeners.add(listener)
+ }
+
+ override suspend fun get(host: String, port: Int, nodeId: SECP256K1.PublicKey): Peer {
+ return get(nodeId, Endpoint(host, port))
+ }
+
+ fun get(nodeId: SECP256K1.PublicKey, endpoint: Endpoint): Peer {
+ dataSource.connection.use { conn ->
+ val stmt = conn.prepareStatement("select id,publickey from identity where publickey=?")
+ stmt.setString(1, nodeId.bytes().toUnprefixedHexString())
+ val rs = stmt.executeQuery()
+ rs.use {
+ if (!rs.next()) {
+ val id = UUID.randomUUID().toString()
+ val insert = conn.prepareStatement("insert into identity(id, publickey) values(?, ?)")
Review comment:
does #56 rs.use close the prepareStatement insert in line #59 ? or maybe it needs another close or a use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824539673
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#209](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a02840e) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e68c5a) will **decrease** coverage by `0.71%`.
> The diff coverage is `24.25%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #209 +/- ##
============================================
- Coverage 65.52% 64.81% -0.72%
- Complexity 4300 4315 +15
============================================
Files 401 410 +9
Lines 21435 21832 +397
Branches 2812 2867 +55
============================================
+ Hits 14046 14150 +104
- Misses 5823 6107 +284
- Partials 1566 1575 +9
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `47.66% <15.88%> (+0.61%)` | `642.00 <0.00> (+5.00)` | |
| unit | `60.26% <24.02%> (-0.65%)` | `4003.00 <15.00> (+15.00)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lin/org/apache/tuweni/devp2p/eth/EthHelloClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NsaWVudC5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/devp2p/eth/EthHelloController.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NvbnRyb2xsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...in/org/apache/tuweni/devp2p/eth/EthHelloHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0hhbmRsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/tuweni/devp2p/eth/EthHelloSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb1N1YnByb3RvY29sLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/tuweni/ethclient/DiscoveryPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0Rpc2NvdmVyeVBlZXJSZXBvc2l0b3J5Lmt0) | `37.50% <0.00%> (-1.64%)` | `4.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/eth/crawler/CrawlerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJBcHAua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lin/org/apache/tuweni/eth/crawler/CrawlerConfig.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJDb25maWcua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/eth/crawler/rest/PeersService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL3Jlc3QvUGVlcnNTZXJ2aWNlLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...n/java/org/apache/tuweni/rlpx/wire/Capability.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9DYXBhYmlsaXR5LmphdmE=) | `50.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e68c5a...a02840e](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824539673
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#209](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3660c2f) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e68c5a) will **decrease** coverage by `0.21%`.
> The diff coverage is `36.02%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #209 +/- ##
============================================
- Coverage 65.52% 65.31% -0.22%
Complexity 4300 4300
============================================
Files 401 404 +3
Lines 21435 21584 +149
Branches 2812 2827 +15
============================================
+ Hits 14046 14098 +52
- Misses 5823 5915 +92
- Partials 1566 1571 +5
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `46.90% <28.57%> (-0.15%)` | `629.00 <0.00> (-8.00)` | |
| unit | `60.76% <35.48%> (-0.16%)` | `3991.00 <4.00> (+3.00)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/tuweni/ethclient/DiscoveryPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0Rpc2NvdmVyeVBlZXJSZXBvc2l0b3J5Lmt0) | `37.50% <0.00%> (-1.64%)` | `4.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/eth/crawler/CrawlerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJBcHAua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lin/org/apache/tuweni/eth/crawler/CrawlerConfig.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJDb25maWcua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...java/org/apache/tuweni/concurrent/ExpiringSet.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvRXhwaXJpbmdTZXQuamF2YQ==) | `45.71% <16.66%> (ø)` | `19.00 <0.00> (ø)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `50.11% <50.00%> (+0.23%)` | `0.00 <0.00> (ø)` | |
| [...che/tuweni/eth/crawler/RelationalPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL1JlbGF0aW9uYWxQZWVyUmVwb3NpdG9yeS5rdA==) | `64.36% <64.36%> (ø)` | `4.00 <4.00> (?)` | |
| [.../kotlin/org/apache/tuweni/devp2p/PeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvUGVlclJlcG9zaXRvcnkua3Q=) | `73.46% <69.23%> (+0.96%)` | `0.00 <0.00> (ø)` | |
| [...ain/kotlin/org/apache/tuweni/relayer/RelayerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aG9iYml0cy1yZWxheWVyL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9yZWxheWVyL1JlbGF5ZXJBcHAua3Q=) | `58.82% <0.00%> (-11.77%)` | `1.00% <0.00%> (-1.00%)` | |
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `64.28% <0.00%> (-5.36%)` | `0.00% <0.00%> (ø%)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e68c5a...3660c2f](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#issuecomment-824539673
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#209](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb0d36e) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/4e68c5a675da3ad0ba09bf274371a40dc4c2eca6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e68c5a) will **decrease** coverage by `5.03%`.
> The diff coverage is `23.23%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #209 +/- ##
============================================
- Coverage 65.52% 60.49% -5.04%
+ Complexity 4300 3992 -308
============================================
Files 401 383 -18
Lines 21435 21301 -134
Branches 2812 2829 +17
============================================
- Hits 14046 12885 -1161
- Misses 5823 6965 +1142
+ Partials 1566 1451 -115
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `60.49% <23.23%> (-0.43%)` | `3992.00 <4.00> (+4.00)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lin/org/apache/tuweni/devp2p/eth/EthHelloClient.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NsaWVudC5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/tuweni/devp2p/eth/EthHelloController.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0NvbnRyb2xsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...in/org/apache/tuweni/devp2p/eth/EthHelloHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb0hhbmRsZXIua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...rg/apache/tuweni/devp2p/eth/EthHelloSubprotocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwLWV0aC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZGV2cDJwL2V0aC9FdGhIZWxsb1N1YnByb3RvY29sLmt0) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `46.82% <0.00%> (-3.06%)` | `0.00 <0.00> (ø)` | |
| [...rc/main/kotlin/org/apache/tuweni/devp2p/Scraper.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvU2NyYXBlci5rdA==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/tuweni/ethclient/DiscoveryPeerRepository.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNsaWVudC9zcmMvbWFpbi9rb3RsaW4vb3JnL2FwYWNoZS90dXdlbmkvZXRoY2xpZW50L0Rpc2NvdmVyeVBlZXJSZXBvc2l0b3J5Lmt0) | `37.50% <0.00%> (-1.64%)` | `4.00 <0.00> (ø)` | |
| [...kotlin/org/apache/tuweni/eth/crawler/CrawlerApp.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJBcHAua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lin/org/apache/tuweni/eth/crawler/CrawlerConfig.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXRoLWNyYXdsZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL2V0aC9jcmF3bGVyL0NyYXdsZXJDb25maWcua3Q=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...n/java/org/apache/tuweni/rlpx/wire/Capability.java](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9DYXBhYmlsaXR5LmphdmE=) | `42.85% <ø> (-7.15%)` | `3.00 <0.00> (-1.00)` | |
| ... and [93 more](https://codecov.io/gh/apache/incubator-tuweni/pull/209/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4e68c5a...cb0d36e](https://codecov.io/gh/apache/incubator-tuweni/pull/209?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme commented on a change in pull request #209: add crawler
Posted by GitBox <gi...@apache.org>.
atoulme commented on a change in pull request #209:
URL: https://github.com/apache/incubator-tuweni/pull/209#discussion_r617921733
##########
File path: eth-crawler/src/main/kotlin/org/apache/tuweni/eth/crawler/RelationalPeerRepository.kt
##########
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tuweni.eth.crawler
+
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
+import org.apache.tuweni.bytes.Bytes
+import org.apache.tuweni.concurrent.AsyncResult
+import org.apache.tuweni.concurrent.coroutines.asyncResult
+import org.apache.tuweni.crypto.SECP256K1
+import org.apache.tuweni.devp2p.Endpoint
+import org.apache.tuweni.devp2p.EthereumNodeRecord
+import org.apache.tuweni.devp2p.Peer
+import org.apache.tuweni.devp2p.PeerRepository
+import org.apache.tuweni.devp2p.parseEnodeUri
+import java.net.URI
+import java.sql.Timestamp
+import java.util.UUID
+import javax.sql.DataSource
+import kotlin.coroutines.CoroutineContext
+
+class RelationalPeerRepository(
+ private val dataSource: DataSource,
+ override val coroutineContext: CoroutineContext = Dispatchers.Default,
+) : CoroutineScope, PeerRepository {
+
+ private val listeners = mutableListOf<(Peer) -> Unit>()
+
+ override fun addListener(listener: (Peer) -> Unit) {
+ listeners.add(listener)
+ }
+
+ override suspend fun get(host: String, port: Int, nodeId: SECP256K1.PublicKey): Peer {
+ return get(nodeId, Endpoint(host, port))
+ }
+
+ fun get(nodeId: SECP256K1.PublicKey, endpoint: Endpoint): Peer {
+ dataSource.connection.use { conn ->
+ val stmt = conn.prepareStatement("select id,publickey from identity where publickey=?")
+ stmt.setString(1, nodeId.bytes().toUnprefixedHexString())
+ val rs = stmt.executeQuery()
+ rs.use {
+ if (!rs.next()) {
+ val id = UUID.randomUUID().toString()
+ val insert = conn.prepareStatement("insert into identity(id, publickey) values(?, ?)")
Review comment:
yes it closes the statement, it's equivalent to try-with-resources IIUC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org