You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by "kenwenzel (via GitHub)" <gi...@apache.org> on 2026/07/04 12:04:17 UTC
[PR] Add Maven wrapper for Jitpack builds. [karaf]
kenwenzel opened a new pull request, #2760:
URL: https://github.com/apache/karaf/pull/2760
Add Maven wrapper to execute Jitpack builds with Maven 3.9.0+.
Fixes #2759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Maven wrapper for Jitpack builds. [karaf]
Posted by "kenwenzel (via GitHub)" <gi...@apache.org>.
kenwenzel commented on PR #2760:
URL: https://github.com/apache/karaf/pull/2760#issuecomment-4889685137
@jbonofre I have two questions:
- Should we add the Maven wrapper even if the Jitpack support is useless (bug mentioned above will not be fixed)?
- The wrapper scripts are automatically generated via `mvn wrapper:wrapper -Dmaven=3.9.16`. Therefore no ASF headers are added. In which files are those headers required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Maven wrapper for Jitpack builds. [karaf]
Posted by "kenwenzel (via GitHub)" <gi...@apache.org>.
kenwenzel commented on PR #2760:
URL: https://github.com/apache/karaf/pull/2760#issuecomment-4885086141
@jbonofre Thank you for the quick reply. I'll fix this.
Unfortunately, karaf builds cleanly on Jitpack but afterwards some artifacts cannot be resolved. I'm invastigating this.
I would only add the wrapper if Jitpack is really working.
Do you enable specific maven profiles when building karaf?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Maven wrapper for Jitpack builds. [karaf]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2760:
URL: https://github.com/apache/karaf/pull/2760#issuecomment-4889698185
@kenwenzel I'm not against adding the mvn wrapper, but I don't think it's strictly required (we live without it for years 😄 ).
Do you really need it? If not, I would just close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Maven wrapper for Jitpack builds. [karaf]
Posted by "kenwenzel (via GitHub)" <gi...@apache.org>.
kenwenzel commented on PR #2760:
URL: https://github.com/apache/karaf/pull/2760#issuecomment-4886350715
Adding Jitpack support is blocked by
https://github.com/jitpack/jitpack.io/issues/8007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Maven wrapper for Jitpack builds. [karaf]
Posted by "kenwenzel (via GitHub)" <gi...@apache.org>.
kenwenzel commented on PR #2760:
URL: https://github.com/apache/karaf/pull/2760#issuecomment-4889725598
@jbonofre I need a snapshot (or intermediate) build of Karaf and I thought it is possible via Jitpack. But Jitpack builds require a maven wrapper to work with recent maven versions.
If snapshot builds can be created (and deployed to a public repository) via other ways (Maven Central or Apache Maven repos) then I'm also happy :-) (see also this discussion https://github.com/apache/karaf/discussions/2752)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Maven wrapper for Jitpack builds. [karaf]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2760:
URL: https://github.com/apache/karaf/pull/2760#issuecomment-4889747686
@kenwenzel alright, you have a new snapshot on the way and I'm fixing the weekly build to have up to date snapshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Maven wrapper for Jitpack builds. [karaf]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #2760:
URL: https://github.com/apache/karaf/pull/2760#issuecomment-4889439346
@kenwenzel the CI is failure is due to a flaky test on Windows. I'm fixing that in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Maven wrapper for Jitpack builds. [karaf]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre closed pull request #2760: Add Maven wrapper for Jitpack builds.
URL: https://github.com/apache/karaf/pull/2760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org