You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David Glasser <gl...@davidglasser.net> on 2007/10/05 23:12:20 UTC
Re: [PATCH] [FSFS] Do not pass txn_id when not used
On 10/5/07, Blair Zajac <bl...@orcaware.com> wrote:
> Daniel L. Rall wrote:
> > On Fri, 05 Oct 2007, Bhuvaneswaran Arumugam wrote:
> >
> >> Hello,
> >>
> >> This fix is similar to r26940. In few of FSFS functions, do not pass
> >> txn_id parameter when it is not used.
> >>
> >> [[
> >> In FSFS libraries, for few functions, do not pass txn_id parameter when
> >> it is not used.
> >>
> >> * subversion/libsvn_fs_fs/dag.h
> >> (svn_fs_fs__dag_finalize_edits): Remove txn_id argument.
> >> Update the comment to reflect this change.
> >> * subversion/libsvn_fs_fs/dag.c
> >> (svn_fs_fs__dag_finalize_edits): Remove txn_id argument.
> >> * subversion/libsvn_fs_fs/tree.c
> >> (update_ancestry): Remove txn_id argument.
> >> (merge, text_stream_closer): Adjust the callers.
> >>
> >> Patch by: bhuvan
> >> ]]
> >
> > Looks good, Bhuvan. +1 to commit.
>
> How come I don't see warnings from gcc on these unused parameters? I guess it
> doesn't it warn when a parameter is not used?
I guess an unused parameter warning could have lots of false positives
from when functions are required to have specific parameter lists for
backwards compatibility reason or to be passed as a function
pointer...
--dave
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] [FSFS] Do not pass txn_id when not used
Posted by Blair Zajac <bl...@orcaware.com>.
David Glasser wrote:
> On 10/5/07, Blair Zajac <bl...@orcaware.com> wrote:
>> Daniel L. Rall wrote:
>>> On Fri, 05 Oct 2007, Bhuvaneswaran Arumugam wrote:
>>>
>>>> Hello,
>>>>
>>>> This fix is similar to r26940. In few of FSFS functions, do not pass
>>>> txn_id parameter when it is not used.
>>>>
>>>> [[
>>>> In FSFS libraries, for few functions, do not pass txn_id parameter when
>>>> it is not used.
>>>>
>>>> * subversion/libsvn_fs_fs/dag.h
>>>> (svn_fs_fs__dag_finalize_edits): Remove txn_id argument.
>>>> Update the comment to reflect this change.
>>>> * subversion/libsvn_fs_fs/dag.c
>>>> (svn_fs_fs__dag_finalize_edits): Remove txn_id argument.
>>>> * subversion/libsvn_fs_fs/tree.c
>>>> (update_ancestry): Remove txn_id argument.
>>>> (merge, text_stream_closer): Adjust the callers.
>>>>
>>>> Patch by: bhuvan
>>>> ]]
>>> Looks good, Bhuvan. +1 to commit.
>> How come I don't see warnings from gcc on these unused parameters? I guess it
>> doesn't it warn when a parameter is not used?
>
> I guess an unused parameter warning could have lots of false positives
> from when functions are required to have specific parameter lists for
> backwards compatibility reason or to be passed as a function
> pointer...
It would be nice if you could enable a command ling option to at least get one
compile with all the warnings and one could go through and look to see if they
are valid or not.
Blair
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org