You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Aleksey Yeschenko (JIRA)" <ji...@apache.org> on 2017/02/05 16:36:41 UTC
[jira] [Updated] (CASSANDRA-9156) Make the echo callback idempotent
in markAlive
[ https://issues.apache.org/jira/browse/CASSANDRA-9156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Yeschenko updated CASSANDRA-9156:
-----------------------------------------
Fix Version/s: (was: 3.x)
4.x
> Make the echo callback idempotent in markAlive
> ----------------------------------------------
>
> Key: CASSANDRA-9156
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9156
> Project: Cassandra
> Issue Type: Improvement
> Components: Distributed Metadata
> Reporter: Stefania
> Priority: Minor
> Fix For: 4.x
>
>
> As discussed in CASSANDRA-7816, in Gossiper.markAlive we send an echo before calling realMarkAlive. However sometimes we send multiple echos before we get an answer and as a consequence realMarkAlive could be called multiple times.
> We should make the echo callback idempotent, i.e., we should make EndpointState#isAlive an AtomicBoolean, and use CAS in EndpointState#markAlive and EndpointState #markDead, returning the CAS result (that is, if it was actually dead and turned alive, and vice-versa): this could be used by the Gossiper to conditionally execute realMarkAlive.
> This would avoid executing realMarkAlive multiple times.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)