You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/05/06 15:57:09 UTC

[GitHub] [druid] suneet-s commented on pull request #9830: Fail incorrectly constructed join queries

suneet-s commented on pull request #9830:
URL: https://github.com/apache/druid/pull/9830#issuecomment-624734779


   > @suneet-s it looks like some tests are failing because Filter.equals is not always implemented. IIRC, nothing depended on that being implemented prior to this patch.
   
   Ha good job tests! I was wondering how I'd get enough coverage to catch issues like this 👍 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org