You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/17 07:14:58 UTC
[GitHub] [rocketmq-client-go] superhx opened a new pull request, #891: (feat): add filter hooks
superhx opened a new pull request, #891:
URL: https://github.com/apache/rocketmq-client-go/pull/891
## Add filter hooks to consumer
Developer can use filter hooks to filter pulled messages before message processing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] lizhanhui commented on pull request #891: (feat): add filter hooks
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #891:
URL: https://github.com/apache/rocketmq-client-go/pull/891#issuecomment-1217717322
It makes sense to have a business tier filter mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #891: (feat): add filter hooks
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #891:
URL: https://github.com/apache/rocketmq-client-go/pull/891#issuecomment-1217667585
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/891?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#891](https://codecov.io/gh/apache/rocketmq-client-go/pull/891?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed62cf0) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/ae76839caba1c718c5b6569682dbc4a931f3f40d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae76839) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #891 +/- ##
==========================================
- Coverage 23.81% 23.77% -0.04%
==========================================
Files 52 52
Lines 7105 7116 +11
==========================================
Hits 1692 1692
- Misses 5187 5198 +11
Partials 226 226
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/891?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [consumer/consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/891/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvY29uc3VtZXIuZ28=) | `17.61% <0.00%> (-0.24%)` | :arrow_down: |
| [consumer/option.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/891/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvb3B0aW9uLmdv) | `20.33% <0.00%> (-0.54%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] lizhanhui commented on pull request #891: (feat): add filter hooks
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #891:
URL: https://github.com/apache/rocketmq-client-go/pull/891#issuecomment-1217720251
@superhx One more thing, you may request this feature [here](https://github.com/apache/rocketmq-clients) too, where the next major version is being built.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] superhx commented on pull request #891: (feat): add filter hooks
Posted by GitBox <gi...@apache.org>.
superhx commented on PR #891:
URL: https://github.com/apache/rocketmq-client-go/pull/891#issuecomment-1217681206
> scenario this featu
1. Java SDK has the FilterMessageHook
2. Don't want send success consumed trace when message is filtered。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] ShannonDing merged pull request #891: [ISSUE #894](feat): add filter hooks in consumer.
Posted by GitBox <gi...@apache.org>.
ShannonDing merged PR #891:
URL: https://github.com/apache/rocketmq-client-go/pull/891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org