[GitHub] aljoscha commented on a change in pull request #7507: [FLINK-10910][e2e] Hardened Kubernetes e2e test.

[GitBox <gi...@apache.org>]

aljoscha commented on a change in pull request #7507: [FLINK-10910][e2e] Hardened Kubernetes e2e test.
URL: https://github.com/apache/flink/pull/7507#discussion_r251812116
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
 ##########
 @@ -37,10 +39,28 @@ function cleanup {
     rm -rf ${OUTPUT_VOLUME}
 }
 
+function check_kubernetes_status {
 
 Review comment:
   I'm guessing these work because the return value of a bash function is implicitly the return value of the last executed command?
   
   Maybe we can make that more explicit so that we don't accidentally break it in the future if someone adds another line after the last line. (This is also something I don't like that much about Scala ...)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services