You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/06/14 12:29:36 UTC

[GitHub] [ignite] ptupitsyn commented on a diff in pull request #10087: IGNITE-17141 Use Maven to build .NET and update versions

ptupitsyn commented on code in PR #10087:
URL: https://github.com/apache/ignite/pull/10087#discussion_r896743133


##########
modules/platforms/cpp/pom.xml:
##########
@@ -0,0 +1,74 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+
+<!--
+    POM file.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <parent>
+        <groupId>org.apache.ignite</groupId>
+        <artifactId>ignite-parent-internal</artifactId>
+        <version>${revision}</version>
+        <relativePath>../../../parent-internal/pom.xml</relativePath>
+    </parent>
+
+    <artifactId>ignite-cpp-thin-client</artifactId>

Review Comment:
   It is not only a thin client. Same as in Java, Ignite C++ can be used as a server, thick client, or thin client.



##########
pom.xml:
##########
@@ -130,6 +130,14 @@
             </modules>
         </profile>
 
+        <profile>
+            <id>thin</id>

Review Comment:
   Let's rename to "platforms" to match the directory name.



##########
modules/platforms/dotnet/pom.xml:
##########
@@ -0,0 +1,132 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+
+<!--
+    POM file.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <parent>
+        <groupId>org.apache.ignite</groupId>
+        <artifactId>ignite-parent-internal</artifactId>
+        <version>${revision}</version>
+        <relativePath>../../../parent-internal/pom.xml</relativePath>
+    </parent>
+
+    <artifactId>ignite-donet-thin-client</artifactId>

Review Comment:
   Same as above - Ignite.NET is not only a thin client. Let's rename to something like "ignite-dotnet".



##########
modules/platforms/dotnet/pom.xml:
##########
@@ -0,0 +1,132 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+
+<!--
+    POM file.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <parent>
+        <groupId>org.apache.ignite</groupId>
+        <artifactId>ignite-parent-internal</artifactId>
+        <version>${revision}</version>
+        <relativePath>../../../parent-internal/pom.xml</relativePath>
+    </parent>
+
+    <artifactId>ignite-donet-thin-client</artifactId>
+    <packaging>pom</packaging>
+
+    <properties>
+        <ignite.thin.full.version>

Review Comment:
   ```suggestion
           <ignite.platform.full.version>
   ```



##########
DEVNOTES.txt:
##########
@@ -42,22 +40,20 @@ Apache Ignite Maven Build Instructions
 
 Apache Ignite with LGPL Maven Build Instructions
 ================================================
-1) Optional: build Apache Ignite.NET as described at modules/platforms/dotnet/DEVNOTES.txt.
-
-2) Compile and install:
+1) Compile and install:
 
         ./mvnw clean install -Pall-java,all-scala,licenses -DskipTests
 
-   or if you have built Apache Ignite.NET on the first step use following command:
-   (Note that 'doxygen' should be installed before running this command.)
+   or if you have to built Apache Ignite with Apache Ignite .NET use following command:

Review Comment:
   ```suggestion
      or if you have to build .NET part as well, use the following command:
   ```



##########
DEVNOTES.txt:
##########
@@ -12,28 +12,26 @@ Further in our documentation, we always use the ./mvnw form. Please adapt it to
 
 Apache Ignite Maven Build Instructions
 ======================================
-1) Optional: build Apache Ignite.NET as described at modules/platforms/dotnet/DEVNOTES.txt.
-
-2) Compile and install:
+1) Compile and install:
 
         ./mvnw clean install -Pall-java,all-scala,licenses -DskipTests
 
-   or if you have built Apache Ignite.NET on the first step use following command:
-   (Note that 'doxygen' should be installed before running this command.)
+   or if you have to built Apache Ignite with Apache Ignite .NET use following command:

Review Comment:
   ```suggestion
      or if you have to build .NET part as well, use the following command:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org