You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Jelmer Vernooij <je...@samba.org> on 2007/07/20 02:13:33 UTC

[PATCH] Fix python bindings for svn.wc.get_prop_diffs()

Hi,

The attached patch fixes the python bindings for
svn.wc.get_prop_diffs(). Patch against trunk.

[[[
Fix Python bindings for svn.wc.get_prop_diffs().

* subversion/bindings/swig/include/svn_containers.swg:
  Add Python typemap for apr_array_header_t * of svn_prop_t *.

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (svn_swig_py_proparray_to_dict): Rename from proparray_to_dict and
make public.

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.h
  (svn_swig_py_proparray_to_dict): Add public prototype.
  
* subversion/bindings/swig/python/tests/wc.py
  (test_get_prop_diffs): Add unit test for svn.wc.get_prop_diffs()

]]]

Please comment if there's any particular reason this patch can't go into
trunk as-is.

Cheers,

Jelmer

Re: [PATCH] Fix python bindings for svn.wc.get_prop_diffs()

Posted by Daniel Rall <dl...@collab.net>.

On Fri, 20 Jul 2007, David James wrote:

> On 7/19/07, Jelmer Vernooij <je...@samba.org> wrote:
> >The attached patch fixes the python bindings for
> >svn.wc.get_prop_diffs(). Patch against trunk.
> 
> Assuming the test passes, +1
> 
> Patch looks good.

Looks good, +1.

- Dan

Re: [PATCH] Fix python bindings for svn.wc.get_prop_diffs()

Posted by David James <ja...@cs.toronto.edu>.

On 7/19/07, Jelmer Vernooij <je...@samba.org> wrote:
> The attached patch fixes the python bindings for
> svn.wc.get_prop_diffs(). Patch against trunk.

Assuming the test passes, +1

Patch looks good.

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org