[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2674: [GOBBLIN-808] implement azkaban flow cancel when dag manager is enabled

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #2674: [GOBBLIN-808] implement azkaban flow cancel when dag manager is enabled
URL: https://github.com/apache/incubator-gobblin/pull/2674#discussion_r296913362
 
 

 ##########
 File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
 ##########
 @@ -151,8 +160,9 @@ public String toString() {
 
   public DagManager(Config config, boolean instrumentationEnabled) {
     this.config = config;
-    this.queue = new LinkedBlockingDeque<>();
     this.numThreads = ConfigUtils.getInt(config, NUM_THREADS_KEY, DEFAULT_NUM_THREADS);
+    this.queue = initializeDagQueue(this.numThreads);
+    this.cancelQueue = initializeDagQueue(this.numThreads);
 
 Review comment:
   Should we just call the queue controlMessageQueue, to handle future cases where we may want to resume execution of a flow?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services