You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Ted-Jiang (via GitHub)" <gi...@apache.org> on 2023/04/25 09:51:59 UTC
[GitHub] [arrow-ballista] Ted-Jiang opened a new pull request, #754: [fea] Avoid multithreaded write lock conflicts in event queue.
Ted-Jiang opened a new pull request, #754:
URL: https://github.com/apache/arrow-ballista/pull/754
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #753.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] Ted-Jiang closed pull request #754: [fea] Avoid multithreaded write lock conflicts in event queue.
Posted by "Ted-Jiang (via GitHub)" <gi...@apache.org>.
Ted-Jiang closed pull request #754: [fea] Avoid multithreaded write lock conflicts in event queue.
URL: https://github.com/apache/arrow-ballista/pull/754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] Ted-Jiang commented on a diff in pull request #754: [fea] Avoid multithreaded write lock conflicts in event queue.
Posted by "Ted-Jiang (via GitHub)" <gi...@apache.org>.
Ted-Jiang commented on code in PR #754:
URL: https://github.com/apache/arrow-ballista/pull/754#discussion_r1176351914
##########
ballista/scheduler/src/scheduler_server/query_stage_scheduler.rs:
##########
@@ -119,44 +119,59 @@ impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan>
let state = self.state.clone();
tokio::spawn(async move {
- let event = if let Err(e) = state
- .submit_job(&job_id, &job_name, session_ctx, &plan, queued_at)
- .await
- {
- let fail_message = format!("Error planning job {job_id}: {e:?}");
- error!("{}", &fail_message);
- QueryStageSchedulerEvent::JobPlanningFailed {
- job_id,
- fail_message,
- queued_at,
- failed_at: timestamp_millis(),
- }
- } else {
- QueryStageSchedulerEvent::JobSubmitted {
- job_id,
- queued_at,
- submitted_at: timestamp_millis(),
- resubmit: false,
- }
- };
+ let event =
+ match state.plan_job(&job_id, session_ctx.clone(), &plan).await {
+ Ok(plan) => QueryStageSchedulerEvent::JobSubmitted {
+ job_id,
+ job_name,
+ session_id: session_ctx.session_id(),
+ queued_at,
+ submitted_at: timestamp_millis(),
+ resubmit: false,
+ plan,
Review Comment:
move the job related status updating to `QueryStageSchedulerEvent::JobSubmitted`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] Ted-Jiang merged pull request #754: [fea] Avoid multithreaded write lock conflicts in event queue.
Posted by "Ted-Jiang (via GitHub)" <gi...@apache.org>.
Ted-Jiang merged PR #754:
URL: https://github.com/apache/arrow-ballista/pull/754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] Ted-Jiang commented on pull request #754: [fea] Avoid multithreaded write lock conflicts in event queue.
Posted by "Ted-Jiang (via GitHub)" <gi...@apache.org>.
Ted-Jiang commented on PR #754:
URL: https://github.com/apache/arrow-ballista/pull/754#issuecomment-1537075063
I will merge this one, If anyone have problem i will be happy to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org