You are viewing a plain text version of this content. The canonical link for it is here.

Posted to devnull@infra.apache.org by "vikasprabhakar (GitHub)" <gi...@apache.org> on 2018/08/23 14:54:16 UTC

[GitHub] [incubator-netbeans] vikasprabhakar opened pull request #774: [NETBEANS-1074]Module Review websvc.design

added 13 graphic files to licenseinfo.xml

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/774 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] junichi11 commented on pull request #774: [NETBEANS-1074]Module Review websvc.design

Posted by "junichi11 (GitHub)" <gi...@apache.org>.

Please add new lines:
```
<!--

    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at

      http://www.apache.org/licenses/LICENSE-2.0

    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.

-->

```

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/774 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] junichi11 commented on pull request #774: [NETBEANS-1074]Module Review websvc.design

Posted by "junichi11 (GitHub)" <gi...@apache.org>.

Please remove the whitespace.

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/774 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] junichi11 commented on pull request #774: [NETBEANS-1074]Module Review websvc.design

Posted by "junichi11 (GitHub)" <gi...@apache.org>.

Please don't use Tabs.

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/774 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] vikasprabhakar commented on issue #774: [NETBEANS-1074]Module Review websvc.design

Posted by "vikasprabhakar (GitHub)" <gi...@apache.org>.

@junichi11 review comments are updated. please review it

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/774 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] junichi11 commented on pull request #774: [NETBEANS-1074]Module Review websvc.design

Posted by "junichi11 (GitHub)" <gi...@apache.org>.

Please remove the whitespaces.

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/774 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] junichi11 closed pull request #774: [NETBEANS-1074]Module Review websvc.design

Posted by "junichi11 (GitHub)" <gi...@apache.org>.

[ pull request closed by junichi11 ]

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/774 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org