You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cayenne.apache.org by GitBox <gi...@apache.org> on 2020/08/19 07:58:19 UTC

[GitHub] [cayenne] andrus commented on pull request #428: CAY-2660 BigDecimal comparision fix

andrus commented on pull request #428:
URL: https://github.com/apache/cayenne/pull/428#issuecomment-675916676


   I just made some minor edits (mostly fixing the typos in type names and javadocs). I don't know if it is possible to add commits to the PR with the Apache setup, so I put it on the new branch: 
   
   * https://github.com/apache/cayenne/commit/33059573867ea5fb34ccb45c5e9ae016e80998c9
   * https://github.com/apache/cayenne/commit/281cc6497940c97ec9f405abf1a29c9080ddf131
   
   But a bigger question that I have is whether we need a new injectable service (ValueComparisonStrategy/ValueComparisonStrategyFactory) to handle it. I suspect using `ValueObjectType`  directly should be enough. IIRC we were afraid of a performance impact of having to pass every value through a `ValueObjectType` . Can we measure it and see if it is of any significance?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org