[jira] [Commented] (BUILDR-664) Checkstyle addon extra_dependencies should not include compile/test libs by default

["Dieter Vrancken (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BUILDR-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619673#comment-13619673 ] 

Dieter Vrancken commented on BUILDR-664:
----------------------------------------

Of course there is an easy work-around for users of the addon, clearing the list during the build: checkstyle.extra_dependencies.clear
                
> Checkstyle addon extra_dependencies should not include compile/test libs by default
> -----------------------------------------------------------------------------------
>
>                 Key: BUILDR-664
>                 URL: https://issues.apache.org/jira/browse/BUILDR-664
>             Project: Buildr
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.4.10
>            Reporter: Dieter Vrancken
>            Priority: Minor
>
> The experimental Buildr::Checkstyle addon contains the following method:
>     def extra_dependencies
>         @extra_dependencies ||= [self.project.compile.dependencies, self.project.test.compile.dependencies].flatten
>     end
> Also, checkstyle itself depends on an ancient version of google-collections library.
> We were bitten by this in that our code depends on a newer version of the guava library (successor to google-collections) in which a method used by checkstyle has been removed.
> Since checkstyle does not require access to the runtime dependencies of the code that is checked, I propose to make the default value of @extra_dependencies empty: [].

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira