You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Gaurav Nagar <gn...@hortonworks.com> on 2017/03/01 11:37:14 UTC

Re: Review Request 57137: Table statistics is not getting computed when 'include columns' is checked

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57137/#review167260
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 28, 2017, 11:24 a.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57137/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 11:24 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20091
>     https://issues.apache.org/jira/browse/AMBARI-20091
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1) analyze table compute stats for columns
> 2) analyze table compute stats
>  
> First one is to collect column statistics and second one is to collect basic stats. numRows, dataSize etc. is computed via 2)
> To get all stats one has to run both statements. 
> 
> Hence implemented in that way.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java 902d959 
>   contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGeneratorSpecTest.groovy PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57137/diff/1/
> 
> 
> Testing
> -------
> 
> added spock test AnalyzeTableQueryGeneratorSpecTest.groovy
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>