You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Clebert Suconic (Jira)" <ji...@apache.org> on 2022/09/21 16:11:00 UTC
[jira] [Closed] (ARTEMIS-3964) Windows ping IPv4/6 commands have wrong time unit
[ https://issues.apache.org/jira/browse/ARTEMIS-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Clebert Suconic closed ARTEMIS-3964.
------------------------------------
Resolution: Fixed
> Windows ping IPv4/6 commands have wrong time unit
> -------------------------------------------------
>
> Key: ARTEMIS-3964
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3964
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Fix For: 2.26.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The ping command on Windows uses
> -w timeout Timeout in milliseconds to wait for each reply. while in code is used seconds.
> {code:java}
> String IPV6_DEFAULT_COMMAND = Env.isWindowsOs() ? "ping -n 1 -w %d %s" :
> ....
> // default int networkTimeout = 1000;
> long timeout = Math.max(1, TimeUnit.MILLISECONDS.toSeconds(networkTimeout));
> ...
> processBuilder = buildProcess(ipv6Command, timeout, address.getCanonicalHostName()
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)