You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by leifurhauks <gi...@git.apache.org> on 2016/06/16 17:29:13 UTC
[GitHub] tinkerpop pull request #340: add RawExpression to gremlin_python
GitHub user leifurhauks opened a pull request:
https://github.com/apache/tinkerpop/pull/340
add RawExpression to gremlin_python
As described on dev@tinkerpop.apache.org thread gremlin_python GLV
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/leifurhauks/incubator-tinkerpop raw_expr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/340.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #340
----
commit 210d1a87fc0532b77ccf67bed57e149982b1e08a
Author: Leifur Halldor Asgeirsson <la...@zerofail.com>
Date: 2016-06-16T14:13:10Z
cpython gitignore
commit e931d21457441e91efc0cfc8b9e70a5a4592b80f
Author: Leifur Halldor Asgeirsson <la...@zerofail.com>
Date: 2016-06-16T15:59:58Z
add RawExpression to gremlin_python
As described on dev@tinkerpop.apache.org thread gremlin_python GLV
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #340: add RawExpression to gremlin_python
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/340
ah - didn't realize that build was hosed in the TINKERPOP-1278 branch itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #340: add RawExpression to gremlin_python
Posted by leifurhauks <gi...@git.apache.org>.
Github user leifurhauks commented on the issue:
https://github.com/apache/tinkerpop/pull/340
@okram , I realized the current implementation of bindings as dicts is breaking 2/3 compatibility. It also makes it bit hairy to extract just the key in `RawExpression`.
I would suggest using a tuple (e.g. `('symbol', value)` ) or a simple class that just has two data members. May I revise the bindings implementation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #340: add RawExpression to gremlin_python
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/340
@leifurhauks do you know why travis is not happy? the build took some errors it seems. Can you please look into that as you push your next change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #340: add RawExpression to gremlin_python
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/340
Please. Use tuple though instead of introducing a new class. Thanks.
> On Jun 16, 2016, at 1:54 PM, Leifur Halldor Asgeirsson <no...@github.com> wrote:
>
> @okram <https://github.com/okram> , I realized the current implementation of bindings as dicts is breaking 2/3 compatibility. It also makes it bit hairy to extract just the key in RawExpression.
>
> I would suggest using a tuple (e.g. ('symbol', value) ) or a simple class that just has two data members. May I revise the bindings implementation?
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <https://github.com/apache/tinkerpop/pull/340#issuecomment-226595005>, or mute the thread <https://github.com/notifications/unsubscribe/AAJFvS3H3oI1-I7llUc6MY03gicy2zI1ks5qManogaJpZM4I3nqp>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #340: add RawExpression to gremlin_python
Posted by leifurhauks <gi...@git.apache.org>.
Github user leifurhauks commented on the issue:
https://github.com/apache/tinkerpop/pull/340
> This is just for the GeoPoint-style adding classes?
More generally, it can be used to create expressions that make use of APIs, presumably provided by the graph vendor, that aren't strictly part of gremlin. My immediate use case is to call static methods on Titan's Geoshape class.
I'll add an example to the asciidoc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #340: add RawExpression to gremlin_python
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/340
How do we use this again? This is just for the `GeoPoint`-style adding classes? Can you provide an example so we can add it to the docs. See:
https://github.com/apache/tinkerpop/blob/TINKERPOP-1278/docs/src/reference/gremlin-variants.asciidoc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #340: add RawExpression to gremlin_python
Posted by leifurhauks <gi...@git.apache.org>.
Github user leifurhauks commented on the issue:
https://github.com/apache/tinkerpop/pull/340
I believe the failures are due to the fact that the aenum package (introduced in 8ee2904 ) is not installed in the CI environment. As a result, the gremlin_python module errors on import.
Since 146f476, the test suite adds the contents of PYTHONPATH to sys.path, but aenum still needs to be downloaded and built. One possibility would be to create a virtualenv in the working dir, install aenum to that virtualenv, and add it to PYTHONPATH.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #340: add RawExpression to gremlin_python
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---