[GitHub] [iceberg] rymurr commented on a change in pull request #2866: [Python] Support schema field ID validation in python

[GitBox <gi...@apache.org>]

rymurr commented on a change in pull request #2866:
URL: https://github.com/apache/iceberg/pull/2866#discussion_r677341450



##########
File path: python/iceberg/api/types/type_util.py
##########
@@ -117,15 +119,17 @@ def visit(arg, visitor): # noqa: ignore=C901
             results = list()
             for field in struct.fields:
                 visitor.field_ids.append(field.field_id)
-                visitor.field_names.append(field.name)
+                visitor.field_names.appendleft(field.name)

Review comment:
       why use a `deque` here?

##########
File path: python/tests/api/types/test_type_util.py
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import unittest
+
+from iceberg.api.types import (BooleanType, NestedField, StructType)
+from iceberg.api.types import type_util
+from iceberg.exceptions import ValidationException
+
+
+class TestConversions(unittest.TestCase):

Review comment:
       we are using `pytest` is there any reason to wrap this single test in a unittest class?

##########
File path: python/iceberg/api/schema.py
##########
@@ -80,6 +82,15 @@ def lazy_lowercase_name_to_id(self):
 
         return self._lowercase_name_to_id
 
+    def lazy_id_to_name(self):
+        from .types import index_by_name

Review comment:
       why the localised import?

##########
File path: python/tests/api/types/test_type_util.py
##########
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import unittest
+
+from iceberg.api.types import (BooleanType, NestedField, StructType)
+from iceberg.api.types import type_util
+from iceberg.exceptions import ValidationException
+
+
+class TestConversions(unittest.TestCase):
+
+    def test_validate_schema_via_index_by_name(self):

Review comment:
       a few more test cases wouldn't be bad. A passing test case. Maybe an obvious wrong one (eg add `a` to the schema twice)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org