You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org> on 2023/04/05 16:22:22 UTC
[GitHub] [superset] Antonio-RiveroMartnez opened a new pull request, #23589: fix(charts): Time range filters are not being applied to charts that were overwritten
Antonio-RiveroMartnez opened a new pull request, #23589:
URL: https://github.com/apache/superset/pull/23589
### SUMMARY
When `GENERIC_CHART_AXES ` FF is on and we overwrite a chart, any filter coming from the dashboard is not saved (it gets removed since its marked as `isExtra`). However, removing such filter doesn't have to mean we delete the original temporal filter if any, otherwise the dashboard wont be able to filter the chart again.
This PR keeps the original `adhoc_filters` from the slice so when calling the PUT API it doesn't get removed. So any call to `api/v1/dashboard/{db_id}/charts` is consistent even after you overwrite the chart.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
### TESTING INSTRUCTIONS
1. Make sure `GENERIC_CHART_AXES` FF is ON
2. Create a chart and add it to a dashboard.
3. Add a time range filter to the dashboard and apply any value.
4. Click on the chart title to access it in the Chart Builder menu.
5. Overwrite the chart (no changes are needed).
6. Go back to the dashboard, and apply any time range filter.
7. The filter must keep working after overwriting the chart
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [X] Required feature flags: `GENERIC_CHART_AXES`
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez commented on pull request #23589: fix(charts): Time range filters are not being applied to charts that were overwritten
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez commented on PR #23589:
URL: https://github.com/apache/superset/pull/23589#issuecomment-1554718809
Hey @justinpark thanks for letting me know. I will have a look as soon as possible 😎
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez merged pull request #23589: fix(charts): Time range filters are not being applied to charts that were overwritten
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez merged PR #23589:
URL: https://github.com/apache/superset/pull/23589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #23589: fix(charts): Time range filters are not being applied to charts that were overwritten
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23589:
URL: https://github.com/apache/superset/pull/23589#issuecomment-1500588027
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #23589: fix(charts): Time range filters are not being applied to charts that were overwritten
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23589:
URL: https://github.com/apache/superset/pull/23589#issuecomment-1500510179
@geido Ephemeral environment spinning up at http://34.211.159.8:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #23589: fix(charts): Time range filters are not being applied to charts that were overwritten
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on PR #23589:
URL: https://github.com/apache/superset/pull/23589#issuecomment-1500508590
/testenv up FEATURE_GENERIC_CHART_AXES=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23589: fix(charts): Time range filters are not being applied to charts that were overwritten
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23589:
URL: https://github.com/apache/superset/pull/23589#issuecomment-1497877538
## [Codecov](https://codecov.io/gh/apache/superset/pull/23589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23589](https://codecov.io/gh/apache/superset/pull/23589?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d781d88) into [master](https://codecov.io/gh/apache/superset/commit/117360cd57bdbf9fd60fc479c6fe64dc077dbfee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (117360c) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head d781d88 differs from pull request most recent head 4ca413c. Consider uploading reports for the commit 4ca413c to get more accurate results
```diff
@@ Coverage Diff @@
## master #23589 +/- ##
=======================================
Coverage 67.72% 67.72%
=======================================
Files 1916 1916
Lines 74029 74034 +5
Branches 8040 8040
=======================================
+ Hits 50135 50141 +6
+ Misses 21846 21845 -1
Partials 2048 2048
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.97% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/explore/actions/saveModalActions.js](https://codecov.io/gh/apache/superset/pull/23589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9zYXZlTW9kYWxBY3Rpb25zLmpz) | `98.75% <100.00%> (+1.41%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #23589: fix(charts): Time range filters are not being applied to charts that were overwritten
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #23589:
URL: https://github.com/apache/superset/pull/23589#issuecomment-1550482644
@Antonio-RiveroMartnez There's a regression from this change.
With this change, user cannot remove the applied adhoc_filters. (Please see the following video. It keeps reverting back the filter option)
https://github.com/apache/superset/assets/1392866/497db3a0-6f72-45d4-800f-fd77da478da9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org