[GitHub] [iotdb] zhanglingzhe0820 commented on a change in pull request #2398: Revert inplace merge

[GitBox <gi...@apache.org>]

zhanglingzhe0820 commented on a change in pull request #2398:
URL: https://github.com/apache/iotdb/pull/2398#discussion_r551267586



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/merge/task/MergeFileTask.java
##########
@@ -225,4 +347,13 @@ private long writeUnmergedChunks(List<Long> chunkStartTimes,
     }
     return maxVersion;
   }
-}
+
+  private File getNextMergeVersionFile(File seqFile) {

Review comment:
       okay, I will fix it

##########
File path: server/src/main/java/org/apache/iotdb/db/engine/merge/task/MergeFileTask.java
##########
@@ -195,7 +318,6 @@ private void moveUnmergedToNew(TsFileResource seqFile) throws IOException {
         ChunkCache.getInstance().clear();
         ChunkMetadataCache.getInstance().clear();
         TimeSeriesMetadataCache.getInstance().clear();
-        FileReaderManager.getInstance().closeFileAndRemoveReader(seqFile.getTsFilePath());

Review comment:
       okay, I will fix it

##########
File path: server/src/main/java/org/apache/iotdb/db/engine/merge/task/MergeFileTask.java
##########
@@ -19,11 +19,17 @@
 
 package org.apache.iotdb.db.engine.merge.task;
 
+import static org.apache.iotdb.tsfile.common.constant.TsFileConstant.TSFILE_SUFFIX;
+
 import java.io.File;
 import java.io.IOException;
+import java.util.HashMap;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
+import java.util.Set;

Review comment:
       okay, I will fix it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org