You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/11 04:02:23 UTC

[GitHub] [spark] gengliangwang commented on pull request #35472: [SPARK-38170][TESTS][SQL] Make ThriftServerWithSparkContextInHttpSuite pass with ANSI enabled

gengliangwang commented on pull request #35472:
URL: https://github.com/apache/spark/pull/35472#issuecomment-1035864329


   >> @gengliangwang I think a unit test should test both ANSI on and ANSI off behaviors regardless of whether we have a new CI job or not, unless the unit test is testing against a particular ANSI behavior.
   
   > @gengliangwang please let me know your opinion. I can make appropriate change if we have a consensus here.
   
   I see.  Either way should be fine then
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org