You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/31 15:08:44 UTC

[GitHub] [flink] tillrohrmann opened a new pull request #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes

tillrohrmann opened a new pull request #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes
URL: https://github.com/apache/flink/pull/10986
 
 
   ## What is the purpose of the change
   
   Add proper NOTICE file to `flink-kubernetes` based on the shaded dependencies. 
   
   cc @GJL 
   
   ## Verifying this change
   
   - Verify via `mvn project-info-reports:dependencies` and `pom.xml` to see what is being shaded.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes
URL: https://github.com/apache/flink/pull/10986#issuecomment-580781859
 
 
   <!--
   Meta data
   Hash:fb5afa3be9eb9a857bb9f2f3c72f5192414d7696 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146942610 TriggerType:PUSH TriggerID:fb5afa3be9eb9a857bb9f2f3c72f5192414d7696
   Hash:fb5afa3be9eb9a857bb9f2f3c72f5192414d7696 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4737 TriggerType:PUSH TriggerID:fb5afa3be9eb9a857bb9f2f3c72f5192414d7696
   -->
   ## CI report:
   
   * fb5afa3be9eb9a857bb9f2f3c72f5192414d7696 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146942610) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4737) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes
URL: https://github.com/apache/flink/pull/10986#issuecomment-580781859
 
 
   <!--
   Meta data
   Hash:fb5afa3be9eb9a857bb9f2f3c72f5192414d7696 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:fb5afa3be9eb9a857bb9f2f3c72f5192414d7696
   -->
   ## CI report:
   
   * fb5afa3be9eb9a857bb9f2f3c72f5192414d7696 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann closed pull request #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes
URL: https://github.com/apache/flink/pull/10986
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes
URL: https://github.com/apache/flink/pull/10986#issuecomment-580772290
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit fb5afa3be9eb9a857bb9f2f3c72f5192414d7696 (Fri Jan 31 15:10:48 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes
URL: https://github.com/apache/flink/pull/10986#issuecomment-580781859
 
 
   <!--
   Meta data
   Hash:fb5afa3be9eb9a857bb9f2f3c72f5192414d7696 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146942610 TriggerType:PUSH TriggerID:fb5afa3be9eb9a857bb9f2f3c72f5192414d7696
   Hash:fb5afa3be9eb9a857bb9f2f3c72f5192414d7696 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4737 TriggerType:PUSH TriggerID:fb5afa3be9eb9a857bb9f2f3c72f5192414d7696
   -->
   ## CI report:
   
   * fb5afa3be9eb9a857bb9f2f3c72f5192414d7696 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146942610) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4737) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann commented on issue #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #10986: [FLINK-15837] Add proper NOTICE file to flink-kubernetes
URL: https://github.com/apache/flink/pull/10986#issuecomment-581354295
 
 
   Thanks for the review @zentol. Merging this PR now.
   
   Good question. I don't know why the `jackson-databind` dependency is set to `2.9.8`. Is there a particular reason for it @wangyang0918? If not, then I would suggest to remove the version tag and rely on dependency management.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services