You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/08 02:42:10 UTC

[GitHub] [arrow] 9prady9 commented on a change in pull request #11887: ARROW-15012: [C++] fixes for msvc environment

9prady9 commented on a change in pull request #11887:
URL: https://github.com/apache/arrow/pull/11887#discussion_r764508105



##########
File path: cpp/src/arrow/util/launder.h
##########
@@ -22,7 +22,7 @@
 namespace arrow {
 namespace internal {
 
-#if __cplusplus >= 201703L
+#ifdef __cpp_lib_launder

Review comment:
       This could be potentially be tested in cross platform way using [newer CMake](https://cmake.org/cmake/help/latest/manual/cmake-compile-features.7.html), but I am not sure if this particular one is added to CMake. Have to check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org