You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Carlos Rovira <ca...@apache.org> on 2017/02/12 23:19:21 UTC
[FlexJS] maven faling (WeakMap)
Hi,
Harbs I think something goes wrong with your last commit. Could you take a
look?
[INFO] Executing COMPC in tool group FlexJS with args:
[-load-config=/Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/target/compile-js-config.xml,
-js-output-type=FLEXJS, -compiler.strict-xml=true]
/Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(45):
col: 31 Access of possibly undefined property WeakMap.
if(typeof WeakMap == "function")
^
/Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(46):
col: 36 Call to a possibly undefined method WeakMap.
_map = new WeakMap();
^
/Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(47):
col: 36 Access of possibly undefined property Map.
else if(typeof Map == "function")//Map is supported,
fall back to that
^
/Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(49):
col: 36 Call to a possibly undefined method Map.
_map = new Map();
^
/Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(58):
col: 32 Access of possibly undefined property Map.
else if(typeof Map == "function")
^
/Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(59):
col: 32 Call to a possibly undefined method Map.
_map = new Map();
^
/Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(165):
col: 28 Call to a possibly undefined method WeakMap.
_map = new WeakMap();
^
/Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(167):
col: 28 Call to a possibly undefined method Map.
_map = new Map();
^
--
Carlos Rovira
http://about.me/carlosrovira
Re: [FlexJS] maven faling (WeakMap)
Posted by piotrz <pi...@gmail.com>.
Guys,
Build is still failing [1]. Can we do something with this?
[1] http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59392.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by piotrz <pi...@gmail.com>.
Alex,
I will try to exclude this class from asdoc.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59395.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by piotrz <pi...@gmail.com>.
If Harbs will not have anything agains I will do that or maybe he will try to
resolve it.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59448.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by Harbs <ha...@gmail.com>.
I think we should fix the asdoc build rather than trying to rename things.
> On Feb 15, 2017, at 10:59 PM, piotrz <pi...@gmail.com> wrote:
>
> Let me experiment with this class and I see whether renaming will help. It's
> valuable addition to FlexJS.
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59474.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by piotrz <pi...@gmail.com>.
Personally I can invest my time into changing ObjectMap and move forward with
other things.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59510.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by Alex Harui <ah...@adobe.com>.
How many folks actually use the FlexJS ASDoc?
Do folks have the cycles to make the ASDoc example a bit better? The dual
branch is pretty much going to force us to give up on using regular Flex
to generate our ASDoc. It might be time to just switch to the ASDoc
example until Chris or others get the DITA-to-HTML conversion working. At
least more of us know how to change MXML and AS in the example than change
the compiler or tweak the XSLT for DITA. And it would be eating our own
dog food.
Thoughts?
-Alex
On 3/5/17, 9:03 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Hi Harby,
>
>Well I have a skeleton using DITA to generate the swf and the js version
>of the asdoc DITA output and was starting to work on something that
>merges the two trees into one and produces xml as output.
>But I was sort of dragged into other things recently so I haven’t done
>much on this.
>
>Right now, I would have to sort of think of a format I can use to
>serialize the DITA information as xml while providing information on if
>stuff is only available only in swf or js … was thinking of something
>like our state-properties in MXML…
>
>As soon as my currently open tasks are closed and the pre-planning of the
>FlexJS summit leaves me some free time, I’ll continue on this.
>
>Chris
>
>Am 05.03.17, 10:38 schrieb "Harbs" <ha...@gmail.com>:
>
> What’s the status one this? (I did not understand the issue very
>well.)
>
> I’m relying on ObjectMap in my code, and it would be nice to have it
>working in the official build. ;-)
>
> > On Feb 16, 2017, at 11:41 AM, Christofer Dutz
><ch...@c-ware.de> wrote:
> >
> > Hi Alex,
> >
> > My current state is that the ASDoc generation uses the DITA output
>to generate the general data structures (It looked as DITA was a lot more
>complete than the others). But in contrast to your version it does two
>compilations … one for JS and one for SWF. Currently
> >
> > What I’m currently working on is to create a tree-walker that
>merges the two and marks elements as “available in both”, “available only
>in js” and “available in swf” and to output that as XML so we can easily
>output HTML and easily customize the output.
> >
> > Chris
> >
> >
> > Am 16.02.17, 00:03 schrieb "Alex Harui" <ah...@adobe.com>:
> >
> >
> >
> > On 2/15/17, 2:46 PM, "Christofer Dutz"
><ch...@c-ware.de> wrote:
> >
> >> Nope … not yet … I’ve got some uncommitted stuff in my local repo,
>but
> >> nothing globally usable yet … still thinking about how to do things
> >> nicely ☺
> >
> > Then that's why it works for Maven. The Ant build currently has
>to use
> > the old Flex SDK MXMLC compiler which doesn't allow "delete" as
>a function
> > name. Once Falcon can generate DITA and you put in place the
>XSLT we'll
> > have the old ASDoc back.
> >
> > Another option is that we invest a bit more in the FlexJS ASDoc
>app and
> > use that for ASDoc for now.
> >
> > Thoughts?
> > -Alex
> >
> >
> >
>
>
>
Re: [FlexJS] maven faling (WeakMap)
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Harby,
Well I have a skeleton using DITA to generate the swf and the js version of the asdoc DITA output and was starting to work on something that merges the two trees into one and produces xml as output.
But I was sort of dragged into other things recently so I haven’t done much on this.
Right now, I would have to sort of think of a format I can use to serialize the DITA information as xml while providing information on if stuff is only available only in swf or js … was thinking of something like our state-properties in MXML…
As soon as my currently open tasks are closed and the pre-planning of the FlexJS summit leaves me some free time, I’ll continue on this.
Chris
Am 05.03.17, 10:38 schrieb "Harbs" <ha...@gmail.com>:
What’s the status one this? (I did not understand the issue very well.)
I’m relying on ObjectMap in my code, and it would be nice to have it working in the official build. ;-)
> On Feb 16, 2017, at 11:41 AM, Christofer Dutz <ch...@c-ware.de> wrote:
>
> Hi Alex,
>
> My current state is that the ASDoc generation uses the DITA output to generate the general data structures (It looked as DITA was a lot more complete than the others). But in contrast to your version it does two compilations … one for JS and one for SWF. Currently
>
> What I’m currently working on is to create a tree-walker that merges the two and marks elements as “available in both”, “available only in js” and “available in swf” and to output that as XML so we can easily output HTML and easily customize the output.
>
> Chris
>
>
> Am 16.02.17, 00:03 schrieb "Alex Harui" <ah...@adobe.com>:
>
>
>
> On 2/15/17, 2:46 PM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>
>> Nope … not yet … I’ve got some uncommitted stuff in my local repo, but
>> nothing globally usable yet … still thinking about how to do things
>> nicely ☺
>
> Then that's why it works for Maven. The Ant build currently has to use
> the old Flex SDK MXMLC compiler which doesn't allow "delete" as a function
> name. Once Falcon can generate DITA and you put in place the XSLT we'll
> have the old ASDoc back.
>
> Another option is that we invest a bit more in the FlexJS ASDoc app and
> use that for ASDoc for now.
>
> Thoughts?
> -Alex
>
>
>
Re: [FlexJS] maven faling (WeakMap)
Posted by Harbs <ha...@gmail.com>.
What’s the status one this? (I did not understand the issue very well.)
I’m relying on ObjectMap in my code, and it would be nice to have it working in the official build. ;-)
> On Feb 16, 2017, at 11:41 AM, Christofer Dutz <ch...@c-ware.de> wrote:
>
> Hi Alex,
>
> My current state is that the ASDoc generation uses the DITA output to generate the general data structures (It looked as DITA was a lot more complete than the others). But in contrast to your version it does two compilations … one for JS and one for SWF. Currently
>
> What I’m currently working on is to create a tree-walker that merges the two and marks elements as “available in both”, “available only in js” and “available in swf” and to output that as XML so we can easily output HTML and easily customize the output.
>
> Chris
>
>
> Am 16.02.17, 00:03 schrieb "Alex Harui" <ah...@adobe.com>:
>
>
>
> On 2/15/17, 2:46 PM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>
>> Nope … not yet … I’ve got some uncommitted stuff in my local repo, but
>> nothing globally usable yet … still thinking about how to do things
>> nicely ☺
>
> Then that's why it works for Maven. The Ant build currently has to use
> the old Flex SDK MXMLC compiler which doesn't allow "delete" as a function
> name. Once Falcon can generate DITA and you put in place the XSLT we'll
> have the old ASDoc back.
>
> Another option is that we invest a bit more in the FlexJS ASDoc app and
> use that for ASDoc for now.
>
> Thoughts?
> -Alex
>
>
>
Re: [FlexJS] maven faling (WeakMap)
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Alex,
My current state is that the ASDoc generation uses the DITA output to generate the general data structures (It looked as DITA was a lot more complete than the others). But in contrast to your version it does two compilations … one for JS and one for SWF. Currently
What I’m currently working on is to create a tree-walker that merges the two and marks elements as “available in both”, “available only in js” and “available in swf” and to output that as XML so we can easily output HTML and easily customize the output.
Chris
Am 16.02.17, 00:03 schrieb "Alex Harui" <ah...@adobe.com>:
On 2/15/17, 2:46 PM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Nope … not yet … I’ve got some uncommitted stuff in my local repo, but
>nothing globally usable yet … still thinking about how to do things
>nicely ☺
Then that's why it works for Maven. The Ant build currently has to use
the old Flex SDK MXMLC compiler which doesn't allow "delete" as a function
name. Once Falcon can generate DITA and you put in place the XSLT we'll
have the old ASDoc back.
Another option is that we invest a bit more in the FlexJS ASDoc app and
use that for ASDoc for now.
Thoughts?
-Alex
Re: [FlexJS] maven faling (WeakMap)
Posted by Alex Harui <ah...@adobe.com>.
On 2/15/17, 2:46 PM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Nope … not yet … I’ve got some uncommitted stuff in my local repo, but
>nothing globally usable yet … still thinking about how to do things
>nicely ☺
Then that's why it works for Maven. The Ant build currently has to use
the old Flex SDK MXMLC compiler which doesn't allow "delete" as a function
name. Once Falcon can generate DITA and you put in place the XSLT we'll
have the old ASDoc back.
Another option is that we invest a bit more in the FlexJS ASDoc app and
use that for ASDoc for now.
Thoughts?
-Alex
Re: [FlexJS] maven faling (WeakMap)
Posted by Christofer Dutz <ch...@c-ware.de>.
Nope … not yet … I’ve got some uncommitted stuff in my local repo, but nothing globally usable yet … still thinking about how to do things nicely ☺
Chris
Am 15.02.17, 23:05 schrieb "Alex Harui" <ah...@adobe.com>:
On 2/15/17, 1:08 PM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Just a short question … is it correct, that currently things are failing
>for Ant and not Maven? (In contrast to this threads subject)
Does the Maven build produce working ASDoc?
-Alex
Re: [FlexJS] maven faling (WeakMap)
Posted by Alex Harui <ah...@adobe.com>.
On 2/15/17, 1:08 PM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Just a short question … is it correct, that currently things are failing
>for Ant and not Maven? (In contrast to this threads subject)
Does the Maven build produce working ASDoc?
-Alex
Re: [FlexJS] maven faling (WeakMap)
Posted by Christofer Dutz <ch...@c-ware.de>.
Just a short question … is it correct, that currently things are failing for Ant and not Maven? (In contrast to this threads subject)
Chris
Am 15.02.17, 21:59 schrieb "piotrz" <pi...@gmail.com>:
Let me experiment with this class and I see whether renaming will help. It's
valuable addition to FlexJS.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59474.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by piotrz <pi...@gmail.com>.
Let me experiment with this class and I see whether renaming will help. It's
valuable addition to FlexJS.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59474.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by Alex Harui <ah...@adobe.com>.
On 2/15/17, 12:48 PM, "Harbs" <ha...@gmail.com> wrote:
>Based on the errors, I don’t think renaming them will be enough.
>
>One of the errors is on Map.delete (which we cannot change)
>
> [asdoc]
>C:\Jenkins\workspace\flex-asjs\frameworks\projects\Core\src\main\flex\org\
>apache\flex\utils\ObjectMap.as(121): col: 32 Error: Syntax error:
>expecting identifier before delete.
> [asdoc]
> [asdoc] this.delete = _map.delete.bind(_map);
> [asdoc] ^
You might have been able to get away with:
_map["delete"].bind(_map);
-Alex
Re: [FlexJS] maven faling (WeakMap)
Posted by Harbs <ha...@gmail.com>.
Based on the errors, I don’t think renaming them will be enough.
One of the errors is on Map.delete (which we cannot change)
[asdoc] C:\Jenkins\workspace\flex-asjs\frameworks\projects\Core\src\main\flex\org\apache\flex\utils\ObjectMap.as(121): col: 32 Error: Syntax error: expecting identifier before delete.
[asdoc]
[asdoc] this.delete = _map.delete.bind(_map);
[asdoc] ^
I can just remove the whole class from CoreClasses for now.
> On Feb 15, 2017, at 6:20 PM, Alex Harui <ah...@adobe.com> wrote:
>
>
>
> On 2/15/17, 4:40 AM, "piotrz" <pi...@gmail.com> wrote:
>
>> I did exclusion, but not sure why it is not working.
>>
>> Maybe Alex can shed some light - I did yesterday changes in config file
>> [1]
>
> I don't know why it is still failing. Maybe the parse phase has to work
> and these excludes only affect the output generation.
>
> Can you try renaming that delete function for now?
>
> -Alex
>
Re: [FlexJS] maven faling (WeakMap)
Posted by Alex Harui <ah...@adobe.com>.
On 2/15/17, 4:40 AM, "piotrz" <pi...@gmail.com> wrote:
>I did exclusion, but not sure why it is not working.
>
>Maybe Alex can shed some light - I did yesterday changes in config file
>[1]
I don't know why it is still failing. Maybe the parse phase has to work
and these excludes only affect the output generation.
Can you try renaming that delete function for now?
-Alex
Re: [FlexJS] maven faling (WeakMap)
Posted by piotrz <pi...@gmail.com>.
I did exclusion, but not sure why it is not working.
Maybe Alex can shed some light - I did yesterday changes in config file [1]
[1] http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/28ce9868
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59437.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by Harbs <ha...@gmail.com>.
That’s the ASDoc problem. I thought you were excluding it.
> On Feb 15, 2017, at 2:13 PM, piotrz <pi...@gmail.com> wrote:
>
> Hi Harbs,
>
> Build is still failing with naming problem:
> http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/2008/console
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59433.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by piotrz <pi...@gmail.com>.
Hi Harbs,
Build is still failing with naming problem:
http://apacheflexbuild.cloudapp.net:8080/job/flex-asjs/2008/console
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59433.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by Harbs <ha...@gmail.com>.
It should now be fixed. It was missing function binding.
> On Feb 15, 2017, at 11:01 AM, Harbs <ha...@gmail.com> wrote:
>
> The names are styled after the Javascript Map and WeakMap classes. I think we should leave them.
>
> Currently, it’s not working because of how I assigned the functions. Renaming them will not help.
>
> I’ll fix that now.
>
>> On Feb 14, 2017, at 11:26 PM, piotrz <pi...@gmail.com> wrote:
>>
>> When I'm looking into ObjectMap class it doesn't look like our AS3 class - I
>> would change names of all methods "get", "set", "delete" etc.
>>
>> My exclude ObjectMap from build didn't work.
>>
>> Piotr
>>
>>
>>
>> -----
>> Apache Flex PMC
>> piotrzarzycki21@gmail.com
>> --
>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59398.html
>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
Re: [FlexJS] maven faling (WeakMap)
Posted by Harbs <ha...@gmail.com>.
The names are styled after the Javascript Map and WeakMap classes. I think we should leave them.
Currently, it’s not working because of how I assigned the functions. Renaming them will not help.
I’ll fix that now.
> On Feb 14, 2017, at 11:26 PM, piotrz <pi...@gmail.com> wrote:
>
> When I'm looking into ObjectMap class it doesn't look like our AS3 class - I
> would change names of all methods "get", "set", "delete" etc.
>
> My exclude ObjectMap from build didn't work.
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59398.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by piotrz <pi...@gmail.com>.
When I'm looking into ObjectMap class it doesn't look like our AS3 class - I
would change names of all methods "get", "set", "delete" etc.
My exclude ObjectMap from build didn't work.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59398.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by piotrz <pi...@gmail.com>.
Harbs,
This is my proposition for naming - taken from C# Dictionary:
delete -> Remove(key)
get -> GetValue(key)
set -> Add(key, value)
has(key) -> ContainsKey(key)
I see that there is no method for checking whether value exists, maybe it is
an good opportunity to have it: ContainsValue(value)
clear() - I would leave as is.
In my opinion also those methods should be same for COMPILE::SWF and
COMPILE::JS - even if we are not reflecting JS API. I wanted to be as far as
we can from JS naming world. :)
What do you think ?
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59414.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by piotrz <pi...@gmail.com>.
Harbs,
If you agree and won't have free cycles today I can do the changes. Sankar
is waiting for Ant build to test my fixes for ->
https://issues.apache.org/jira/browse/FLEX-35256
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-maven-faling-WeakMap-tp59270p59415.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [FlexJS] maven faling (WeakMap)
Posted by Alex Harui <ah...@adobe.com>.
On 2/13/17, 10:14 AM, "Harbs" <ha...@gmail.com> wrote:
>I can change that.
>
>I named the methods the same as the JS Map/WeakMap ones, but we can give
>them other names.
Well, if you are emulating a JS API, it should probably have the same
name. A short term fix for the build is to exclude ObjectMap from the
ASDoc.
-Alex
Re: [FlexJS] maven faling (WeakMap)
Posted by Harbs <ha...@gmail.com>.
I can change that.
I named the methods the same as the JS Map/WeakMap ones, but we can give them other names.
> On Feb 13, 2017, at 6:02 PM, Alex Harui <ah...@adobe.com> wrote:
>
>
>
> On 2/13/17, 2:28 AM, "carlos.rovira@gmail.com on behalf of Carlos Rovira"
> <carlos.rovira@gmail.com on behalf of carlos.rovira@codeoscopic.com> wrote:
>
>> Discussion about Map/WeakMap comes due to the fact we have Dictionary in
>> Flash but no counterpart in JS, so our FlexJS class should use Map/WeakMap
>> in JS and Dictionary on SWF.
>>
>> But for Iterator, I think we had that in AS3Commons right?
>
> Could be, but IMO, in many ways, we want to use structured JS constructs
> where we can, so there is no overhead in the JS output. So sure, add JS
> Iterators if you need them, maybe to the Collections.swc. If you need
> generics to do it, it will have to wait.
>
> Regarding ObjectMap, it is currently breaking the build because we use the
> regular Flex SDK to compile the ASDoc and it doesn't like having methods
> named "delete". Can that be changed or do we need to put more energy into
> having Falcon generate our ASDoc?
>
> -Alex
>
Re: [FlexJS] maven faling (WeakMap)
Posted by Alex Harui <ah...@adobe.com>.
On 2/13/17, 2:28 AM, "carlos.rovira@gmail.com on behalf of Carlos Rovira"
<carlos.rovira@gmail.com on behalf of carlos.rovira@codeoscopic.com> wrote:
>Discussion about Map/WeakMap comes due to the fact we have Dictionary in
>Flash but no counterpart in JS, so our FlexJS class should use Map/WeakMap
>in JS and Dictionary on SWF.
>
>But for Iterator, I think we had that in AS3Commons right?
Could be, but IMO, in many ways, we want to use structured JS constructs
where we can, so there is no overhead in the JS output. So sure, add JS
Iterators if you need them, maybe to the Collections.swc. If you need
generics to do it, it will have to wait.
Regarding ObjectMap, it is currently breaking the build because we use the
regular Flex SDK to compile the ASDoc and it doesn't like having methods
named "delete". Can that be changed or do we need to put more energy into
having Falcon generate our ASDoc?
-Alex
Re: [FlexJS] maven faling (WeakMap)
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Discussion about Map/WeakMap comes due to the fact we have Dictionary in
Flash but no counterpart in JS, so our FlexJS class should use Map/WeakMap
in JS and Dictionary on SWF.
But for Iterator, I think we had that in AS3Commons right?
2017-02-13 11:24 GMT+01:00 Harbs <ha...@gmail.com>:
> My question is more about how to deal with Flash.
>
> There is currently no IIterator in Flex. We can add one. The question is
> whether we want to.
>
> Creating an iterator is pretty straight-forward.
>
> > On Feb 13, 2017, at 11:33 AM, Carlos Rovira <
> carlos.rovira@codeoscopic.com> wrote:
> >
> > Hi Harbs,
> >
> > if Map/WeakMap are already in some browsers, I will check for a polyfill
> so
> > the browser could rely on native implementation if there's someone, or
> use
> > the polyfill in browsers where there's nothing. I did something similar
> in
> > Dialog.as in MDL. I think in this way we are going with the standard and
> as
> > browsers implement the feature the polyfill will fallback to native
> > implementation.
> >
> > Thanks
> >
> >
> >
> > El 13 de febrero de 2017, 10:16, Harbs <ha...@gmail.com> escribió:
> >
> >> Another thing to discuss:
> >> Map has iterators. I’m not sure the best way to generalize that for
> >> cross-platform support.
> >>
> >>> On Feb 13, 2017, at 10:56 AM, Harbs <ha...@gmail.com> wrote:
> >>>
> >>> BTW:
> >>> ObjectMap is horribly inefficient. I’m working on fixing it.
> >>>
> >>>> On Feb 13, 2017, at 10:18 AM, Carlos Rovira <
> >> carlos.rovira@codeoscopic.com> wrote:
> >>>>
> >>>> Build is working again.
> >>>> Thanks!
> >>>>
> >>>>
> >>>>
> >>>> 2017-02-13 7:36 GMT+01:00 Alex Harui <ah...@adobe.com>:
> >>>>
> >>>>> Hopefully I fixed it.
> >>>>>
> >>>>> On 2/12/17, 3:25 PM, "Harbs" <ha...@gmail.com> wrote:
> >>>>>
> >>>>>> It compiles in ant. It looks like the Maven build does not recognize
> >>>>>> ES2015 APIs. I don’t know how to point it to the right typedefs.
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>>>
> >>>> --
> >>>>
> >>>> Carlos Rovira
> >>>> Director General
> >>>> M: +34 607 22 60 05
> >>>> http://www.codeoscopic.com
> >>>> http://www.avant2.es
> >>>>
> >>>> Este mensaje se dirige exclusivamente a su destinatario y puede
> contener
> >>>> información privilegiada o confidencial. Si ha recibido este mensaje
> por
> >>>> error, le rogamos que nos lo comunique inmediatamente por esta misma
> >> vía y
> >>>> proceda a su destrucción.
> >>>>
> >>>> De la vigente Ley Orgánica de Protección de Datos (15/1999), le
> >> comunicamos
> >>>> que sus datos forman parte de un fichero cuyo responsable es
> CODEOSCOPIC
> >>>> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> >>>> servicio o información solicitados, teniendo usted derecho de acceso,
> >>>> rectificación, cancelación y oposición de sus datos dirigiéndose a
> >> nuestras
> >>>> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la
> documentación
> >>>> necesaria.
> >>>
> >>
> >>
> >
> >
> > --
> >
> > Carlos Rovira
> > Director General
> > M: +34 607 22 60 05 <607%2022%2060%2005>
> > http://www.codeoscopic.com
> > http://www.avant2.es
> >
> > Este mensaje se dirige exclusivamente a su destinatario y puede contener
> > información privilegiada o confidencial. Si ha recibido este mensaje por
> > error, le rogamos que nos lo comunique inmediatamente por esta misma vía
> y
> > proceda a su destrucción.
> >
> > De la vigente Ley Orgánica de Protección de Datos (15/1999), le
> comunicamos
> > que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
> > S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> > servicio o información solicitados, teniendo usted derecho de acceso,
> > rectificación, cancelación y oposición de sus datos dirigiéndose a
> nuestras
> > oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
> > necesaria.
>
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: [FlexJS] maven faling (WeakMap)
Posted by Harbs <ha...@gmail.com>.
My question is more about how to deal with Flash.
There is currently no IIterator in Flex. We can add one. The question is whether we want to.
Creating an iterator is pretty straight-forward.
> On Feb 13, 2017, at 11:33 AM, Carlos Rovira <ca...@codeoscopic.com> wrote:
>
> Hi Harbs,
>
> if Map/WeakMap are already in some browsers, I will check for a polyfill so
> the browser could rely on native implementation if there's someone, or use
> the polyfill in browsers where there's nothing. I did something similar in
> Dialog.as in MDL. I think in this way we are going with the standard and as
> browsers implement the feature the polyfill will fallback to native
> implementation.
>
> Thanks
>
>
>
> El 13 de febrero de 2017, 10:16, Harbs <ha...@gmail.com> escribió:
>
>> Another thing to discuss:
>> Map has iterators. I’m not sure the best way to generalize that for
>> cross-platform support.
>>
>>> On Feb 13, 2017, at 10:56 AM, Harbs <ha...@gmail.com> wrote:
>>>
>>> BTW:
>>> ObjectMap is horribly inefficient. I’m working on fixing it.
>>>
>>>> On Feb 13, 2017, at 10:18 AM, Carlos Rovira <
>> carlos.rovira@codeoscopic.com> wrote:
>>>>
>>>> Build is working again.
>>>> Thanks!
>>>>
>>>>
>>>>
>>>> 2017-02-13 7:36 GMT+01:00 Alex Harui <ah...@adobe.com>:
>>>>
>>>>> Hopefully I fixed it.
>>>>>
>>>>> On 2/12/17, 3:25 PM, "Harbs" <ha...@gmail.com> wrote:
>>>>>
>>>>>> It compiles in ant. It looks like the Maven build does not recognize
>>>>>> ES2015 APIs. I don’t know how to point it to the right typedefs.
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Carlos Rovira
>>>> Director General
>>>> M: +34 607 22 60 05
>>>> http://www.codeoscopic.com
>>>> http://www.avant2.es
>>>>
>>>> Este mensaje se dirige exclusivamente a su destinatario y puede contener
>>>> información privilegiada o confidencial. Si ha recibido este mensaje por
>>>> error, le rogamos que nos lo comunique inmediatamente por esta misma
>> vía y
>>>> proceda a su destrucción.
>>>>
>>>> De la vigente Ley Orgánica de Protección de Datos (15/1999), le
>> comunicamos
>>>> que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
>>>> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
>>>> servicio o información solicitados, teniendo usted derecho de acceso,
>>>> rectificación, cancelación y oposición de sus datos dirigiéndose a
>> nuestras
>>>> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
>>>> necesaria.
>>>
>>
>>
>
>
> --
>
> Carlos Rovira
> Director General
> M: +34 607 22 60 05 <607%2022%2060%2005>
> http://www.codeoscopic.com
> http://www.avant2.es
>
> Este mensaje se dirige exclusivamente a su destinatario y puede contener
> información privilegiada o confidencial. Si ha recibido este mensaje por
> error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
> proceda a su destrucción.
>
> De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
> que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> servicio o información solicitados, teniendo usted derecho de acceso,
> rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
> necesaria.
Re: [FlexJS] maven faling (WeakMap)
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Hi Harbs,
if Map/WeakMap are already in some browsers, I will check for a polyfill so
the browser could rely on native implementation if there's someone, or use
the polyfill in browsers where there's nothing. I did something similar in
Dialog.as in MDL. I think in this way we are going with the standard and as
browsers implement the feature the polyfill will fallback to native
implementation.
Thanks
El 13 de febrero de 2017, 10:16, Harbs <ha...@gmail.com> escribió:
> Another thing to discuss:
> Map has iterators. I’m not sure the best way to generalize that for
> cross-platform support.
>
> > On Feb 13, 2017, at 10:56 AM, Harbs <ha...@gmail.com> wrote:
> >
> > BTW:
> > ObjectMap is horribly inefficient. I’m working on fixing it.
> >
> >> On Feb 13, 2017, at 10:18 AM, Carlos Rovira <
> carlos.rovira@codeoscopic.com> wrote:
> >>
> >> Build is working again.
> >> Thanks!
> >>
> >>
> >>
> >> 2017-02-13 7:36 GMT+01:00 Alex Harui <ah...@adobe.com>:
> >>
> >>> Hopefully I fixed it.
> >>>
> >>> On 2/12/17, 3:25 PM, "Harbs" <ha...@gmail.com> wrote:
> >>>
> >>>> It compiles in ant. It looks like the Maven build does not recognize
> >>>> ES2015 APIs. I don’t know how to point it to the right typedefs.
> >>>
> >>>
> >>>
> >>
> >>
> >> --
> >>
> >> Carlos Rovira
> >> Director General
> >> M: +34 607 22 60 05
> >> http://www.codeoscopic.com
> >> http://www.avant2.es
> >>
> >> Este mensaje se dirige exclusivamente a su destinatario y puede contener
> >> información privilegiada o confidencial. Si ha recibido este mensaje por
> >> error, le rogamos que nos lo comunique inmediatamente por esta misma
> vía y
> >> proceda a su destrucción.
> >>
> >> De la vigente Ley Orgánica de Protección de Datos (15/1999), le
> comunicamos
> >> que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
> >> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> >> servicio o información solicitados, teniendo usted derecho de acceso,
> >> rectificación, cancelación y oposición de sus datos dirigiéndose a
> nuestras
> >> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
> >> necesaria.
> >
>
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05 <607%2022%2060%2005>
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: [FlexJS] maven faling (WeakMap)
Posted by Harbs <ha...@gmail.com>.
Another thing to discuss:
Map has iterators. I’m not sure the best way to generalize that for cross-platform support.
> On Feb 13, 2017, at 10:56 AM, Harbs <ha...@gmail.com> wrote:
>
> BTW:
> ObjectMap is horribly inefficient. I’m working on fixing it.
>
>> On Feb 13, 2017, at 10:18 AM, Carlos Rovira <ca...@codeoscopic.com> wrote:
>>
>> Build is working again.
>> Thanks!
>>
>>
>>
>> 2017-02-13 7:36 GMT+01:00 Alex Harui <ah...@adobe.com>:
>>
>>> Hopefully I fixed it.
>>>
>>> On 2/12/17, 3:25 PM, "Harbs" <ha...@gmail.com> wrote:
>>>
>>>> It compiles in ant. It looks like the Maven build does not recognize
>>>> ES2015 APIs. I don’t know how to point it to the right typedefs.
>>>
>>>
>>>
>>
>>
>> --
>>
>> Carlos Rovira
>> Director General
>> M: +34 607 22 60 05
>> http://www.codeoscopic.com
>> http://www.avant2.es
>>
>> Este mensaje se dirige exclusivamente a su destinatario y puede contener
>> información privilegiada o confidencial. Si ha recibido este mensaje por
>> error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
>> proceda a su destrucción.
>>
>> De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
>> que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
>> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
>> servicio o información solicitados, teniendo usted derecho de acceso,
>> rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
>> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
>> necesaria.
>
Re: [FlexJS] maven faling (WeakMap)
Posted by Harbs <ha...@gmail.com>.
BTW:
ObjectMap is horribly inefficient. I’m working on fixing it.
> On Feb 13, 2017, at 10:18 AM, Carlos Rovira <ca...@codeoscopic.com> wrote:
>
> Build is working again.
> Thanks!
>
>
>
> 2017-02-13 7:36 GMT+01:00 Alex Harui <ah...@adobe.com>:
>
>> Hopefully I fixed it.
>>
>> On 2/12/17, 3:25 PM, "Harbs" <ha...@gmail.com> wrote:
>>
>>> It compiles in ant. It looks like the Maven build does not recognize
>>> ES2015 APIs. I don’t know how to point it to the right typedefs.
>>
>>
>>
>
>
> --
>
> Carlos Rovira
> Director General
> M: +34 607 22 60 05
> http://www.codeoscopic.com
> http://www.avant2.es
>
> Este mensaje se dirige exclusivamente a su destinatario y puede contener
> información privilegiada o confidencial. Si ha recibido este mensaje por
> error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
> proceda a su destrucción.
>
> De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
> que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> servicio o información solicitados, teniendo usted derecho de acceso,
> rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
> necesaria.
Re: [FlexJS] maven faling (WeakMap)
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Build is working again.
Thanks!
2017-02-13 7:36 GMT+01:00 Alex Harui <ah...@adobe.com>:
> Hopefully I fixed it.
>
> On 2/12/17, 3:25 PM, "Harbs" <ha...@gmail.com> wrote:
>
> >It compiles in ant. It looks like the Maven build does not recognize
> >ES2015 APIs. I don’t know how to point it to the right typedefs.
>
>
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: [FlexJS] maven faling (WeakMap)
Posted by Alex Harui <ah...@adobe.com>.
Hopefully I fixed it.
On 2/12/17, 3:25 PM, "Harbs" <ha...@gmail.com> wrote:
>It compiles in ant. It looks like the Maven build does not recognize
>ES2015 APIs. I don’t know how to point it to the right typedefs.
Re: [FlexJS] maven faling (WeakMap)
Posted by Harbs <ha...@gmail.com>.
It compiles in ant. It looks like the Maven build does not recognize ES2015 APIs. I don’t know how to point it to the right typedefs.
> On Feb 13, 2017, at 1:19 AM, Carlos Rovira <ca...@apache.org> wrote:
>
> Hi,
>
> Harbs I think something goes wrong with your last commit. Could you take a
> look?
>
> [INFO] Executing COMPC in tool group FlexJS with args:
> [-load-config=/Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/target/compile-js-config.xml,
> -js-output-type=FLEXJS, -compiler.strict-xml=true]
>
> /Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(45):
> col: 31 Access of possibly undefined property WeakMap.
>
>
> if(typeof WeakMap == "function")
>
> ^
>
>
> /Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(46):
> col: 36 Call to a possibly undefined method WeakMap.
>
>
> _map = new WeakMap();
>
> ^
>
>
> /Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(47):
> col: 36 Access of possibly undefined property Map.
>
>
> else if(typeof Map == "function")//Map is supported,
> fall back to that
>
> ^
>
>
> /Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(49):
> col: 36 Call to a possibly undefined method Map.
>
>
> _map = new Map();
>
> ^
>
>
> /Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(58):
> col: 32 Access of possibly undefined property Map.
>
>
> else if(typeof Map == "function")
>
> ^
>
>
> /Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(59):
> col: 32 Call to a possibly undefined method Map.
>
>
> _map = new Map();
>
> ^
>
>
> /Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(165):
> col: 28 Call to a possibly undefined method WeakMap.
>
>
> _map = new WeakMap();
>
> ^
>
>
> /Users/carlosrovira/Dev/Flex/source/flexjs/flex-asjs/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/ObjectMap.as(167):
> col: 28 Call to a possibly undefined method Map.
>
>
> _map = new Map();
>
> ^
>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira