You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2016/10/24 21:39:13 UTC
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Alex Behm has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4827
Change subject: Removed dead join inversion code from Analyzer.
......................................................................
Removed dead join inversion code from Analyzer.
Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
1 file changed, 0 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/4827/1
--
To view, visit http://gerrit.cloudera.org:8080/4827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Removed dead join inversion code from Analyzer.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: Removed dead join inversion code from Analyzer.
......................................................................
Patch Set 1:
I ran the code analysis tool from my IDE and found huge amount of un-used code in the frontend. I haven't verified each item but Analyzer class shows the following ones.
- isSubquery()
- resetSubquery()
- containsOuterjoinedTid(List<TupleId>)
- getEquivSlots(SlotId)
- removeRedundantExprs(List<Expr>)
- isConjunctAssigned(Expr)
- hasUnassignedConjuncts()
- getTargetDbName(FunctionName)
- getConjunct(ExprId)
- getEqJoinConjuncts()
- validateValueTransferGraph)
As per the analysis there are 4533 such warnings across the code :)
--
To view, visit http://gerrit.cloudera.org:8080/4827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: Removed dead join inversion code from Analyzer.
......................................................................
Patch Set 2:
Sure I can take over. Most of these can be fixed using "Quick Fix" by the IDE. I'll take a look.
--
To view, visit http://gerrit.cloudera.org:8080/4827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Removed dead join inversion code from Analyzer.
......................................................................
Patch Set 2: Code-Review-1
Do you want to take over the patch Bharath? Please keep in mind that some code (even if unused) is still useful, for example, validateValueTransferGraph().
--
To view, visit http://gerrit.cloudera.org:8080/4827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Removed dead join inversion code from Analyzer.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: Removed dead join inversion code from Analyzer.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: Removed dead join inversion code from Analyzer.
......................................................................
Patch Set 1:
The above ones I pasted are apart from invertOuterJoinState() you removed here.
--
To view, visit http://gerrit.cloudera.org:8080/4827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Removed dead join inversion code from Analyzer.
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has abandoned this change.
Change subject: Removed dead join inversion code from Analyzer.
......................................................................
Abandoned
As discussed with Alex, I'm abandoning this change and will submit a new change with a larger cleanup.
--
To view, visit http://gerrit.cloudera.org:8080/4827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I9d8fff29c0f6b239796561c877acc709a178c108
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins