[jira] Commented: (JCR-388) add support for RFC 3253 to the simple server

["jeremi Joslin (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/JCR-388?page=comments#action_12416608 ] 

jeremi Joslin commented on JCR-388:
-----------------------------------

Hi,
i've started again to work on the deltav.
Some things I don't understand in your comments :
ResourceFactoryImpl:
-------------------------------------------------------------------------------
>- createResource(DavResourceLocator, DavServletRequest request, DavServletResponse)
> always builds a DavResourceImpl. However it should be
>  possible to access a Version, VersionHistory as resource
>  from a request -> missing impl.
>  Note that DavResourceFactory#createResource(DavResourceLocator, DavSession)
>  is mainly used from within the resources to build the collection
>  and members.

  I don't think so because i call createResource(DavResourceLocator locator, DavSession session) after.


DeltaVResourceImpl
-------------------------------------------------------------------------------                        

>- addHrefProperty(DavPropertyName, Node[], boolean)
> > i think, it would be better to replace this by 
>    'getHrefProperty(DavPropertyName, Node[], boolean)' which returns
>    the property instead of adding it directely to the prop-set.
>    
>  > there seems to be an error while building the href.
>    it's a speciality of the original code, that Nodes are
>    represented as collections and javax.jcr.Property objects aren't.
>    in the 'simple' server this is different -> needs to check if the
>    given node represents a collection or not.

I don't understand what you want i do.


VersionControlledResourceImpl
-------------------------------------------------------------------------------                       

> - getVersionHistory:
>   added check if factory really created a vh-resource
Why we don't trust the factory?

Thanks,
Jérémi

> add support for RFC 3253 to the simple server
> ---------------------------------------------
>
>          Key: JCR-388
>          URL: http://issues.apache.org/jira/browse/JCR-388
>      Project: Jackrabbit
>         Type: New Feature

>   Components: webdav
>     Versions: 0.9
>     Reporter: jeremi Joslin
>     Assignee: angela
>     Priority: Minor
>  Attachments: Review.txt, patch_rfc3253.zip, rfc.zip
>
> http://www.ietf.org/rfc/rfc3253.txt

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira