You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "xiaoyimei (GitHub)" <gi...@apache.org> on 2018/08/24 08:05:03 UTC
[GitHub] [incubator-servicecomb-service-center] xiaoyimei opened pull request #431: [SCB-809]Verify the chinese version of the UI as all chinese text was…
… translated using Google Translate
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
[ Full content available at: https://github.com/apache/incubator-servicecomb-service-center/pull/431 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-servicecomb-service-center] coveralls commented
on issue #431: [SCB-809]Verify the chinese version of the UI
Posted by "coveralls (GitHub)" <gi...@apache.org>.
[](https://coveralls.io/builds/18681301)
Coverage increased (+0.02%) to 72.102% when pulling **3938d927b85ab45d9d76753246f89d7b57f7023c on xiaoyimei:SCB-809** into **77ae91e5adc580861358a814096dd0f824073dc5 on apache:master**.
[ Full content available at: https://github.com/apache/incubator-servicecomb-service-center/pull/431 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-servicecomb-service-center] yangbor commented on
pull request #431: [SCB-809]Verify the chinese version of the UI
Posted by "yangbor (GitHub)" <gi...@apache.org>.
It should be '告警' in APM scenario.
[ Full content available at: https://github.com/apache/incubator-servicecomb-service-center/pull/431 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-servicecomb-service-center] xiaoyimei commented
on pull request #431: [SCB-809]Verify the chinese version of the UI
Posted by "xiaoyimei (GitHub)" <gi...@apache.org>.
I know, thank you.
[ Full content available at: https://github.com/apache/incubator-servicecomb-service-center/pull/431 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-servicecomb-service-center] xiaoyimei commented
on pull request #431: [SCB-809]Verify the chinese version of the UI
Posted by "xiaoyimei (GitHub)" <gi...@apache.org>.
got it.
[ Full content available at: https://github.com/apache/incubator-servicecomb-service-center/pull/431 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-servicecomb-service-center] yangbor commented on
pull request #431: [SCB-809]Verify the chinese version of the UI
Posted by "yangbor (GitHub)" <gi...@apache.org>.
This should be kept as '提供者'. In ServiceComb it's used under 'service providers'
[ Full content available at: https://github.com/apache/incubator-servicecomb-service-center/pull/431 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-servicecomb-service-center] asifdxtreme closed
pull request #431: [SCB-809]Verify the chinese version of the UI
Posted by "asifdxtreme (GitHub)" <gi...@apache.org>.
[ pull request closed by asifdxtreme ]
[ Full content available at: https://github.com/apache/incubator-servicecomb-service-center/pull/431 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-servicecomb-service-center] coveralls commented
on issue #431: [SCB-809]Verify the chinese version of the UI
Posted by "coveralls (GitHub)" <gi...@apache.org>.
[](https://coveralls.io/builds/18648459)
Coverage decreased (-0.02%) to 72.058% when pulling **f4b939565664113048be8bf152694c8c49392522 on xiaoyimei:SCB-809** into **77ae91e5adc580861358a814096dd0f824073dc5 on apache:master**.
[ Full content available at: https://github.com/apache/incubator-servicecomb-service-center/pull/431 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-servicecomb-service-center] codecov-io commented
on issue #431: [SCB-809]Verify the chinese version of the UI
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/431?src=pr&el=h1) Report
> Merging [#431](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/77ae91e5adc580861358a814096dd0f824073dc5?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/431?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #431 +/- ##
=======================================
Coverage 69.22% 69.22%
=======================================
Files 139 139
Lines 10770 10770
=======================================
Hits 7455 7455
Misses 2839 2839
Partials 476 476
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/431?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/core/backend/metrics.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/431/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9tZXRyaWNzLmdv) | `71.42% <0%> (-14.29%)` | :arrow_down: |
| [server/plugin/infra/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/431/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL3RyYWNpbmcuZ28=) | `72.72% <0%> (-9.1%)` | :arrow_down: |
| [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/431/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: |
| [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/431/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `84.37% <0%> (+3.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/431?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/431?src=pr&el=footer). Last update [77ae91e...f4b9395](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-servicecomb-service-center/pull/431 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org