You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ddanielr (via GitHub)" <gi...@apache.org> on 2023/02/02 20:25:34 UTC

[GitHub] [accumulo] ddanielr opened a new pull request, #3184: Switch log level back to debug

ddanielr opened a new pull request, #3184:
URL: https://github.com/apache/accumulo/pull/3184

   The exceptions thrown here are already logged at the error level via the calling method `modifySystemProperties` from the
   `ManagerClientServiceHandler` class.
   
   https://github.com/apache/accumulo/blob/2.1/server/manager/src/main/java/org/apache/accumulo/manager/ManagerClientServiceHandler.java#L461-L462
   
   Writing these exceptions at the error level would result in duplicate exception messages in the logs.
   
   Switching these back to only log the exceptions at the debug level.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] dlmarion merged pull request #3184: Switch log level to trace

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #3184:
URL: https://github.com/apache/accumulo/pull/3184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] ddanielr commented on a diff in pull request #3184: Switch log level back to debug

Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on code in PR #3184:
URL: https://github.com/apache/accumulo/pull/3184#discussion_r1095076041


##########
server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java:
##########
@@ -76,13 +76,13 @@ private static String validateSystemProperty(String property, final String value
     if (!Property.isValidZooPropertyKey(property)) {
       IllegalArgumentException iae =
           new IllegalArgumentException("Zookeeper property is not mutable: " + property);
-      log.error("Encountered error setting zookeeper property", iae);
+      log.debug("Encountered error setting zookeeper property", iae);

Review Comment:
   I agree that `debug` is commonly used for "general awareness" instead of `Info`.
   
   So I'm happy to switch to `trace` but I'd like to also switch all instances of `debug` in SystemPropUtil if they are already logged in their calling methods. 
   
   Outside of this PR, maybe a overhaul of logging should be considered to help reduce the need for `debug` use in production environments? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] EdColeman commented on a diff in pull request #3184: Switch log level to trace

Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on code in PR #3184:
URL: https://github.com/apache/accumulo/pull/3184#discussion_r1095086052


##########
server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java:
##########
@@ -76,13 +76,13 @@ private static String validateSystemProperty(String property, final String value
     if (!Property.isValidZooPropertyKey(property)) {
       IllegalArgumentException iae =
           new IllegalArgumentException("Zookeeper property is not mutable: " + property);
-      log.error("Encountered error setting zookeeper property", iae);
+      log.debug("Encountered error setting zookeeper property", iae);

Review Comment:
   I would be fine with switching them to trace if they are logged by the calling methods.
   
   A review / overhauling of the logging is probably overdue, but also too large of a task to handle at one time.  One factor is there are down-stream users that may be processing the logs and it is really difficult to know exactly what information is important at a given time.  Most of the time, it seems like noise. Until that one time you need to figure out X and then you start wishing there were more details ;-)
   
   There is a start at unifying things with the  org.apache.accumulo.core.logging.Logging class.  Using and extending that could help reduce the scope of the problem moving forward.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] EdColeman commented on a diff in pull request #3184: Switch log level back to debug

Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on code in PR #3184:
URL: https://github.com/apache/accumulo/pull/3184#discussion_r1095069679


##########
server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java:
##########
@@ -76,13 +76,13 @@ private static String validateSystemProperty(String property, final String value
     if (!Property.isValidZooPropertyKey(property)) {
       IllegalArgumentException iae =
           new IllegalArgumentException("Zookeeper property is not mutable: " + property);
-      log.error("Encountered error setting zookeeper property", iae);
+      log.debug("Encountered error setting zookeeper property", iae);

Review Comment:
   Consider removing or using trace.  The error logged by the calling method should be enough - and usually systems seem to run with logging set to debug because we  do not seem to log enough information at info or above to adequately troubleshoot issues when they occur.  (Which is a whole other topic) Sorry I was not clearer on my earlier comment. 



##########
server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java:
##########
@@ -76,13 +76,13 @@ private static String validateSystemProperty(String property, final String value
     if (!Property.isValidZooPropertyKey(property)) {
       IllegalArgumentException iae =
           new IllegalArgumentException("Zookeeper property is not mutable: " + property);
-      log.error("Encountered error setting zookeeper property", iae);
+      log.debug("Encountered error setting zookeeper property", iae);
       throw iae;
     }
     if (!Property.isValidProperty(property, value)) {
       IllegalArgumentException iae = new IllegalArgumentException(
           "Property " + property + " with value: " + value + " is not valid");
-      log.error("Encountered error setting zookeeper property", iae);
+      log.debug("Encountered error setting zookeeper property", iae);

Review Comment:
   Please consider trace (see earlier comment)



##########
server/base/src/main/java/org/apache/accumulo/server/util/SystemPropUtil.java:
##########
@@ -100,7 +100,7 @@ private static String validateSystemProperty(String property, final String value
         && !foundProp.getType().isValidFormat(value)))) {
       IllegalArgumentException iae = new IllegalArgumentException(
           "Ignoring property " + property + " it is either null or in an invalid format");
-      log.error("Attempted to set zookeeper property.  Value is either null or invalid", iae);
+      log.debug("Attempted to set zookeeper property.  Value is either null or invalid", iae);

Review Comment:
   Please consider trace (see earlier comment)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org