You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jclouds.apache.org by Everett Toews <no...@github.com> on 2013/12/16 16:07:18 UTC

[jclouds-labs-openstack] The update method in the Claim API. (#64)

https://issues.apache.org/jira/browse/JCLOUDS-340

Related:
* [PATCH method does not work in HTTPS connections or in HTTP with a body](https://issues.apache.org/jira/browse/JCLOUDS-405)
* https://github.com/jclouds/jclouds/pull/230
You can merge this Pull Request by running:

  git pull https://github.com/rackerlabs/jclouds-labs-openstack marconi-update-claim-2

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-openstack/pull/64

-- Commit Summary --

  * The update method in the Claim API.

-- File Changes --

    M openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/features/ClaimApi.java (19)
    M openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/ClaimApiLiveTest.java (13)
    M openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/ClaimApiMockTest.java (28)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-openstack/pull/64.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/64.diff

Re: [jclouds-labs-openstack] The update method in the Claim API. (#64)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-labs-openstack-pull-requests #116](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/116/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/64#issuecomment-30667831

Re: [jclouds-labs-openstack] The update method in the Claim API. (#64)

Posted by Ignasi Barrera <no...@github.com>.

Note that although mock and live tests are passing, the PATCH method will only work in HTTPS connections (will fail in HTTP) until https://github.com/jclouds/jclouds/pull/232 is fixed and merged.

This LGTM, btw!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/64#issuecomment-30667665

Re: [jclouds-labs-openstack] The update method in the Claim API. (#64)

Posted by Everett Toews <no...@github.com>.

Yep. I had to disable the (HTTP) mock test because of that.

Thanks @nacx!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/64#issuecomment-30669331