You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/01/09 20:53:39 UTC
[GitHub] [httpcomponents-client] hboutemy opened a new pull request #276: improve documentation format
hboutemy opened a new pull request #276:
URL: https://github.com/apache/httpcomponents-client/pull/276
these improvements are useful in master branch, whatever happens to current discussions on testing and eventually changing some structure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on pull request #276: improve documentation format
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #276:
URL: https://github.com/apache/httpcomponents-client/pull/276#issuecomment-757373905
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy commented on pull request #276: improve documentation format
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #276:
URL: https://github.com/apache/httpcomponents-client/pull/276#issuecomment-757373683
@michael-o
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #276: improve documentation format
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #276:
URL: https://github.com/apache/httpcomponents-client/pull/276#issuecomment-757739586
@hboutemy Unfortunately the build is still failing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy commented on pull request #276: improve documentation format
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #276:
URL: https://github.com/apache/httpcomponents-client/pull/276#issuecomment-757373683
@michael-o
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c merged pull request #276: improve documentation format
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #276:
URL: https://github.com/apache/httpcomponents-client/pull/276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy commented on a change in pull request #276: improve documentation format
Posted by GitBox <gi...@apache.org>.
hboutemy commented on a change in pull request #276:
URL: https://github.com/apache/httpcomponents-client/pull/276#discussion_r554638653
##########
File path: src/site/site.xml
##########
@@ -0,0 +1,88 @@
+<?xml version="1.0" encoding="ISO-8859-1"?>
Review comment:
license header updated: now rat is ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on pull request #276: improve documentation format
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #276:
URL: https://github.com/apache/httpcomponents-client/pull/276#issuecomment-757373949
@ok2c HC Site is not forgotten, but lockdown is giving me a hard time right now. I will try to engage next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on pull request #276: improve documentation format
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #276:
URL: https://github.com/apache/httpcomponents-client/pull/276#issuecomment-757373905
Will have a look next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on a change in pull request #276: improve documentation format
Posted by GitBox <gi...@apache.org>.
ok2c commented on a change in pull request #276:
URL: https://github.com/apache/httpcomponents-client/pull/276#discussion_r554599697
##########
File path: src/site/site.xml
##########
@@ -0,0 +1,88 @@
+<?xml version="1.0" encoding="ISO-8859-1"?>
Review comment:
@hboutemy It looks like Apache RAT chokes on this file
```
[INFO] --- apache-rat-plugin:0.13:check (default) @ httpclient5-parent ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from /home/travis/build/apache/httpcomponents-client/.gitignore
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 76 implicit excludes (use -debug for more details).
[INFO] 9 explicit excludes (use -debug for more details).
[INFO] 16 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 1, unknown: 1, generated: 0, approved: 8 licenses.
[INFO] ------------------------------------------------------------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org