[GitHub] [hudi] lw309637554 commented on a change in pull request #2254: [HUDI-1350] Support Partition level delete API in HUDI

[GitBox <gi...@apache.org>]

lw309637554 commented on a change in pull request #2254:
URL: https://github.com/apache/hudi/pull/2254#discussion_r544436529



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java
##########
@@ -157,6 +157,15 @@ private synchronized FileSystemViewManager getViewManager() {
    */
   public abstract HoodieWriteMetadata<O> delete(HoodieEngineContext context, String instantTime, K keys);
 
+  /**
+   * Deletes all data of partitions.
+   * @param context    HoodieEngineContext
+   * @param instantTime Instant Time for the action
+   * @param partitions   {@link List} of partition to be deleted
+   * @return HoodieWriteMetadata
+   */
+  public abstract HoodieWriteMetadata deletePartitions(HoodieEngineContext context, String instantTime, List<String> partitions);

Review comment:
       thanks, i thinks "List<String>" will be ok. Because flink and spark will implement HoodieTable, use javaRDD not suitable to flink.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org