You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/04/21 11:00:26 UTC
[GitHub] [incubator-inlong] healchow opened a new pull request, #3875: [INLONG-3874][Manager] Abstract the operator class for creating Sink resources
healchow opened a new pull request, #3875:
URL: https://github.com/apache/incubator-inlong/pull/3875
### Title Name: [INLONG-3874][Manager] Abstract the operator class for creating Sink resources
Fixes #3874
### Motivation
[INLONG-3874][Manager] Abstract the operator class for creating Sink resources.
### Verifying this change
- [X] This change is a trivial rework/code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #3875: [INLONG-3874][Manager] Abstract the operator class for creating Sink resources
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #3875:
URL: https://github.com/apache/incubator-inlong/pull/3875#discussion_r856034985
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/FullSinkInfo.java:
##########
@@ -21,11 +21,11 @@
import lombok.Data;
/**
- * Sink info for Sort
+ * Full sink info - with stream
*/
@Data
-@ApiModel("Sink info for Sort")
-public class SinkForSortDTO {
+@ApiModel("Full sink info")
+public class FullSinkInfo {
Review Comment:
OK, change it to `SinkInfo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] kipshi commented on a diff in pull request #3875: [INLONG-3874][Manager] Abstract the operator class for creating Sink resources
Posted by GitBox <gi...@apache.org>.
kipshi commented on code in PR #3875:
URL: https://github.com/apache/incubator-inlong/pull/3875#discussion_r855967673
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/FullSinkInfo.java:
##########
@@ -21,11 +21,11 @@
import lombok.Data;
/**
- * Sink info for Sort
+ * Full sink info - with stream
*/
@Data
-@ApiModel("Sink info for Sort")
-public class SinkForSortDTO {
+@ApiModel("Full sink info")
+public class FullSinkInfo {
Review Comment:
FullSinkInfo is not clean to understand, try another name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #3875: [INLONG-3874][Manager] Abstract the operator class for creating Sink resources
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #3875:
URL: https://github.com/apache/incubator-inlong/pull/3875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org