You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2021/04/02 03:15:48 UTC
[Impala-ASF-CR] [PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17265
Change subject: [PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
......................................................................
[PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
Change-Id: I10a7657a479610ccb551162dd8d1247fd2514a6d
---
M be/src/util/parse-util.cc
M testdata/bin/generate-schema-statements.py
M tests/benchmark/report_benchmark_results.py
M tests/common/test_dimensions.py
M tests/performance/query.py
5 files changed, 94 insertions(+), 54 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/17265/1
--
To view, visit http://gerrit.cloudera.org:8080/17265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I10a7657a479610ccb551162dd8d1247fd2514a6d
Gerrit-Change-Number: 17265
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] [PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17265
to look at the new patch set (#2).
Change subject: [PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
......................................................................
[PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
Change-Id: I10a7657a479610ccb551162dd8d1247fd2514a6d
---
M be/src/util/parse-util.cc
M testdata/bin/generate-schema-statements.py
M tests/benchmark/report_benchmark_results.py
M tests/common/test_dimensions.py
M tests/performance/query.py
M tests/util/test_file_parser.py
6 files changed, 95 insertions(+), 63 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/17265/2
--
To view, visit http://gerrit.cloudera.org:8080/17265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I10a7657a479610ccb551162dd8d1247fd2514a6d
Gerrit-Change-Number: 17265
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17265 )
Change subject: [PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
......................................................................
Patch Set 1:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/17265/1/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:
http://gerrit.cloudera.org:8080/#/c/17265/1/testdata/bin/generate-schema-statements.py@489
PS1, Line 489: def build_insert(insert, db_name, db_suffix, file_format, codec, compression_type,
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py
File tests/benchmark/report_benchmark_results.py:
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py@425
PS1, Line 425:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py@425
PS1, Line 425:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py@464
PS1, Line 464:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py@464
PS1, Line 464:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py@1041
PS1, Line 1041:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py@1041
PS1, Line 1041:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py@56
PS1, Line 56: ,
flake8: W602 deprecated form of raising exception
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py@56
PS1, Line 56: e
flake8: E501 line too long (94 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py@60
PS1, Line 60: c
flake8: F841 local variable 'compression_level_int' is assigned to but never used
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py@62
PS1, Line 62: ,
flake8: W602 deprecated form of raising exception
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py@94
PS1, Line 94: ,
flake8: W602 deprecated form of raising exception
http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py@94
PS1, Line 94: l
flake8: E501 line too long (95 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/17265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10a7657a479610ccb551162dd8d1247fd2514a6d
Gerrit-Change-Number: 17265
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Apr 2021 03:16:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17265 )
Change subject: [PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8498/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10a7657a479610ccb551162dd8d1247fd2514a6d
Gerrit-Change-Number: 17265
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Apr 2021 03:35:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17265 )
Change subject: [PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8499/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10a7657a479610ccb551162dd8d1247fd2514a6d
Gerrit-Change-Number: 17265
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 03 Apr 2021 01:52:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17265 )
Change subject: [PROTOTYPE] IMPALA-10630: Support negative compression levels for ZSTD
......................................................................
Patch Set 2:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/17265/2/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:
http://gerrit.cloudera.org:8080/#/c/17265/2/testdata/bin/generate-schema-statements.py@489
PS2, Line 489: def build_insert(insert, db_name, db_suffix, file_format, codec, compression_type,
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/benchmark/report_benchmark_results.py
File tests/benchmark/report_benchmark_results.py:
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/benchmark/report_benchmark_results.py@425
PS2, Line 425:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/benchmark/report_benchmark_results.py@425
PS2, Line 425:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/benchmark/report_benchmark_results.py@464
PS2, Line 464:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/benchmark/report_benchmark_results.py@464
PS2, Line 464:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/benchmark/report_benchmark_results.py@1041
PS2, Line 1041:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/benchmark/report_benchmark_results.py@1041
PS2, Line 1041:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/common/test_dimensions.py@56
PS2, Line 56: ,
flake8: W602 deprecated form of raising exception
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/common/test_dimensions.py@56
PS2, Line 56: e
flake8: E501 line too long (94 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/common/test_dimensions.py@60
PS2, Line 60: c
flake8: F841 local variable 'compression_level_int' is assigned to but never used
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/common/test_dimensions.py@62
PS2, Line 62: ,
flake8: W602 deprecated form of raising exception
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/common/test_dimensions.py@94
PS2, Line 94: ,
flake8: W602 deprecated form of raising exception
http://gerrit.cloudera.org:8080/#/c/17265/2/tests/common/test_dimensions.py@94
PS2, Line 94: l
flake8: E501 line too long (95 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/17265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10a7657a479610ccb551162dd8d1247fd2514a6d
Gerrit-Change-Number: 17265
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 03 Apr 2021 01:33:38 +0000
Gerrit-HasComments: Yes