You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by cl...@apache.org on 2017/03/01 01:24:10 UTC

activemq-artemis git commit: ARTEMIS-1006: JDBC should log proper warns with stack traces on SQLExceptions

Repository: activemq-artemis
Updated Branches:
  refs/heads/master 87d6c3500 -> 70721dcd5


ARTEMIS-1006: JDBC should log proper warns with stack traces on SQLExceptions


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/70721dcd
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/70721dcd
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/70721dcd

Branch: refs/heads/master
Commit: 70721dcd5c68aaaa9c14e5df328471518d43db42
Parents: 87d6c35
Author: Clebert Suconic <cl...@apache.org>
Authored: Tue Feb 28 20:18:41 2017 -0500
Committer: Clebert Suconic <cl...@apache.org>
Committed: Tue Feb 28 20:23:54 2017 -0500

----------------------------------------------------------------------
 .../activemq/artemis/jdbc/store/journal/JDBCJournalImpl.java     | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/70721dcd/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/JDBCJournalImpl.java
----------------------------------------------------------------------
diff --git a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/JDBCJournalImpl.java b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/JDBCJournalImpl.java
index dbab0e6..eb7cda1 100644
--- a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/JDBCJournalImpl.java
+++ b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/JDBCJournalImpl.java
@@ -198,6 +198,7 @@ public class JDBCJournalImpl extends AbstractJDBCDriver implements Journal {
             }
          }
       } catch (SQLException e) {
+         logger.warn(e.getMessage(), e);
          executeCallbacks(recordRef, success);
          return 0;
       }
@@ -212,6 +213,7 @@ public class JDBCJournalImpl extends AbstractJDBCDriver implements Journal {
          connection.commit();
          success = true;
       } catch (SQLException e) {
+         logger.warn(e.getMessage(), e);
          performRollback(recordRef);
       }
 
@@ -276,6 +278,7 @@ public class JDBCJournalImpl extends AbstractJDBCDriver implements Journal {
             }
          }
       } catch (Exception sqlE) {
+         logger.warn(sqlE.getMessage(), sqlE);
          ActiveMQJournalLogger.LOGGER.error("Error performing rollback", sqlE);
       }
    }
@@ -670,6 +673,7 @@ public class JDBCJournalImpl extends AbstractJDBCDriver implements Journal {
          rs.next();
          count = rs.getInt(1);
       } catch (SQLException e) {
+         logger.warn(e.getMessage(), e);
          return -1;
       }
       return count;