[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6581: arch: Correct the order of stack related information in assert

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #6581:
URL: https://github.com/apache/incubator-nuttx/pull/6581#discussion_r915932360


##########
arch/risc-v/src/common/riscv_assert.c:
##########
@@ -291,26 +283,18 @@ static inline void riscv_showtasks(void)
   _alert("  ----   ----"
 #  ifdef CONFIG_SMP
          "  ----"
-#  endif
-#  ifdef CONFIG_STACK_COLORATION
-         "   %7lu"
 #  endif
          "   %7lu"
 #  ifdef CONFIG_STACK_COLORATION
-         "   %3" PRId32 ".%1" PRId32 "%%%c"
+         "   %7lu   %3" PRId32 ".%1" PRId32 "%%%c"
 #  endif
 #  ifdef CONFIG_SCHED_CPULOAD
          "     ----"
 #  endif
-#  if CONFIG_TASK_NAME_SIZE > 0
-         "   irq"
-#  endif
-         "\n"
-#  ifdef CONFIG_STACK_COLORATION
-         , (unsigned long)stack_used
-#  endif
+         "   irq\n"
          , (unsigned long)(CONFIG_ARCH_INTERRUPTSTACK & ~15)
 #  ifdef CONFIG_STACK_COLORATION
+         , (unsigned long)stack_used

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org