You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/29 06:42:20 UTC
[GitHub] [flink] Tartarus0zm opened a new pull request, #19608: [FLINK-27450][hive][JDK11]SessionState can't be initialized due to classloader
Tartarus0zm opened a new pull request, #19608:
URL: https://github.com/apache/flink/pull/19608
## What is the purpose of the change
Refer to [HIVE-21237](https://issues.apache.org/jira/browse/HIVE-21237), choose hive version 2.3.7 to support jdk11
## Brief change log
* update hive version to 2.3.7
## Verifying this change
no
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #19608: [FLINK-27450][hive][JDK11]SessionState can't be initialized due to classloader
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on PR #19608:
URL: https://github.com/apache/flink/pull/19608#issuecomment-1120176654
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19608: [FLINK-27450][hive][JDK11]SessionState can't be initialized due to classloader
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19608:
URL: https://github.com/apache/flink/pull/19608#issuecomment-1112926048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "73c7995521b8a054fe5a15173ebb2769a5aca401",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "73c7995521b8a054fe5a15173ebb2769a5aca401",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 73c7995521b8a054fe5a15173ebb2769a5aca401 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #19608: [FLINK-27450][hive][JDK11]SessionState can't be initialized due to classloader
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on PR #19608:
URL: https://github.com/apache/flink/pull/19608#issuecomment-1120577173
@MartijnVisser @luoyuxia CI has passed, please take a look, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19608: [FLINK-27450][hive][JDK11]SessionState can't be initialized due to classloader
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19608:
URL: https://github.com/apache/flink/pull/19608#issuecomment-1112951082
@Tartarus0zm Hive doesn't support Java 11, see https://issues.apache.org/jira/browse/HIVE-22415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #19608: [FLINK-27450][hive][JDK11]SessionState can't be initialized due to classloader
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #19608:
URL: https://github.com/apache/flink/pull/19608#issuecomment-1120605580
@Tartarus0zm LGTM. But could you please update the pr titile like "[FLINK-27450][hive] Upgrade default hive-exec version to fix Hive SessionState initialization issue in jdk11"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #19608: [FLINK-27450][hive][JDK11]SessionState can't be initialized due to classloader
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on PR #19608:
URL: https://github.com/apache/flink/pull/19608#issuecomment-1118223620
> > This PR is to solve the problem that the current HiveParserSessionState cannot be initialized under JDK11.
>
> Can you explain how that helps if Hive doesn't work under Java 11?
@MartijnVisser AppClassLoader is a subclass of URLClassLoader in JDK8, but AppClassLoader is no longer a subclass of URLClassLoader in JDK11.
The low version Hive SessionState code is like this,
```
final ClassLoader currentLoader = Utilities.createUDFClassLoader((URLClassLoader) parentLoader, new String[]{});
```
Therefore, running with jdk11 will report an error, versions after 2.3.6 fixed this problem.
[HIVE-21584]([https://issues.apache.org/jira/browse/HIVE-21584]) fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #19608: [FLINK-27450][hive] Upgrade default hive version to fix Hive SessionState initialization issue with jdk11
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #19608:
URL: https://github.com/apache/flink/pull/19608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19608: [FLINK-27450][hive] Upgrade default hive version to fix Hive SessionState initialization issue with jdk11
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19608:
URL: https://github.com/apache/flink/pull/19608#issuecomment-1122286579
@Tartarus0zm Can you please squash commits & rebase? I can merge it afterwards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #19608: [FLINK-27450][hive][JDK11]SessionState can't be initialized due to classloader
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on PR #19608:
URL: https://github.com/apache/flink/pull/19608#issuecomment-1112958784
> @Tartarus0zm Hive doesn't support Java 11, see https://issues.apache.org/jira/browse/HIVE-22415
Yes, hive doesn't fully support jdk11 yet.
This PR is to solve the problem that the current HiveParserSessionState cannot be initialized under JDK11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #19608: [FLINK-27450][hive][JDK11]SessionState can't be initialized due to classloader
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19608:
URL: https://github.com/apache/flink/pull/19608#discussion_r861562644
##########
pom.xml:
##########
@@ -149,7 +149,7 @@ under the License.
to revisit the impact at that time.
-->
<minikdc.version>3.2.0</minikdc.version>
- <hive.version>2.3.4</hive.version>
+ <hive.version>2.3.7</hive.version>
Review Comment:
As we will also offically provide flink-sql-connector-hive-2.3.9.jar, could you please update it to 2.3.9 and verify it in with jdk 11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #19608: [FLINK-27450][hive][JDK11]SessionState can't be initialized due to classloader
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on PR #19608:
URL: https://github.com/apache/flink/pull/19608#issuecomment-1112930329
@wuchong @luoyuxia @beyond1920 please take a look if you have time, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19608: [FLINK-27450][hive][JDK11]SessionState can't be initialized due to classloader
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19608:
URL: https://github.com/apache/flink/pull/19608#issuecomment-1114549234
> This PR is to solve the problem that the current HiveParserSessionState cannot be initialized under JDK11.
Can you explain how that helps if Hive doesn't work under Java 11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19608: [FLINK-27450][hive][JDK11]SessionState can't be initialized due to classloader
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19608:
URL: https://github.com/apache/flink/pull/19608#issuecomment-1119526421
> Therefore, running with jdk11 will report an error, versions after 2.3.6 fixed this problem.
> HIVE-21584 fixed it.
Thanks for clarifying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #19608: [FLINK-27450][hive] Upgrade default hive version to fix Hive SessionState initialization issue with jdk11
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on PR #19608:
URL: https://github.com/apache/flink/pull/19608#issuecomment-1123146246
> @Tartarus0zm Can you please squash commits & rebase? I can merge it afterwards
@MartijnVisser yes, I has squash commits & rebase. Let's wait for CI to pass. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #19608: [FLINK-27450][hive] Upgrade default hive version to fix Hive SessionState initialization issue with jdk11
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on PR #19608:
URL: https://github.com/apache/flink/pull/19608#issuecomment-1120613738
> @Tartarus0zm LGTM. But could you please update the pr titile like "[[FLINK-27450](https://issues.apache.org/jira/browse/FLINK-27450)][hive] Upgrade default hive-exec version to fix Hive SessionState initialization issue with jdk11"
@luoyuxia Thank you for your reminder, we have modified the default hive version, not only the hive-exec version, so I changed the title to `[[FLINK-27450](https://issues.apache.org/jira/browse/FLINK-27450)] [hive] Upgrade default hive version to fix Hive SessionState initialization issue with jdk11`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org