You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "RexXiong (via GitHub)" <gi...@apache.org> on 2023/04/04 07:30:01 UTC
[GitHub] [incubator-celeborn] RexXiong opened a new pull request, #1409: [CELEBORN-503][FLINK] fix attempt task may use wrong partitionId.
RexXiong opened a new pull request, #1409:
URL: https://github.com/apache/incubator-celeborn/pull/1409
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Use context partitionId to apply new slots.
### Why are the changes needed?
Flink task may retry register with new attemptId while lifecycle manager still offer slots for the attempt 0 tasks.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Random kill workers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1409: [CELEBORN-503][FLINK] fix attempt task may use wrong partitionId.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1409:
URL: https://github.com/apache/incubator-celeborn/pull/1409#issuecomment-1495499312
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1409?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1409](https://codecov.io/gh/apache/incubator-celeborn/pull/1409?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d391915) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/c3e8189e629ec6b125f663210dc3a0c41c5b3641?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c3e8189) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
+ Coverage 45.01% 45.05% +0.05%
==========================================
Files 164 164
Lines 10404 10404
Branches 1057 1057
==========================================
+ Hits 4682 4687 +5
+ Misses 5381 5378 -3
+ Partials 341 339 -2
```
[see 2 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1409/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong merged pull request #1409: [CELEBORN-503][FLINK] fix attempt task may use wrong partitionId.
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong merged PR #1409:
URL: https://github.com/apache/incubator-celeborn/pull/1409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org