You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/17 05:22:54 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #7134: [enhancement] display load bytes in show load stmt
yangzhg opened a new pull request #7134:
URL: https://github.com/apache/incubator-doris/pull/7134
## Proposed changes
display current load bytes to show load progress,
this value may greate than the file size when loading
parquert or orc file, will less than file size when loading
csv file.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [x] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #7134: [enhancement] display load bytes in show load stmt
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #7134:
URL: https://github.com/apache/incubator-doris/pull/7134#discussion_r752399627
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/loadv2/BrokerLoadJob.java
##########
@@ -346,6 +346,16 @@ private void updateLoadingStatus(BrokerLoadingTaskAttachment attachment) {
}
}
+ @Override
+ public void updateProgress(Long beId, TUniqueId loadId, TUniqueId fragmentId, long scannedRows,
+ long scannedBytes, boolean isDone) {
+ super.updateProgress(beId, loadId, fragmentId, scannedRows, scannedBytes, isDone);
+ progress = (int) ((double) loadStatistic.getLoadBytes() / loadStatistic.totalFileSizeB * 100);
Review comment:
This may always larger than 100, when loading parquet or orc format files.
##########
File path: be/src/exec/tablet_sink.cpp
##########
@@ -707,13 +707,15 @@ Status OlapTableSink::open(RuntimeState* state) {
Status OlapTableSink::send(RuntimeState* state, RowBatch* input_batch) {
SCOPED_TIMER(_profile->total_time_counter());
- _number_input_rows += input_batch->num_rows();
// update incrementally so that FE can get the progress.
// the real 'num_rows_load_total' will be set when sink being closed.
- state->update_num_rows_load_total(input_batch->num_rows());
- state->update_num_bytes_load_total(input_batch->total_byte_size());
- DorisMetrics::instance()->load_rows->increment(input_batch->num_rows());
- DorisMetrics::instance()->load_bytes->increment(input_batch->total_byte_size());
+ int64_t num_rows = input_batch->num_rows();
+ int64_t num_bytes = input_batch->total_byte_size();
Review comment:
Pay attention that `total_byte_size()` may cost times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7134: [enhancement] display load bytes in show load stmt
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7134:
URL: https://github.com/apache/incubator-doris/pull/7134#issuecomment-976566681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #7134: [enhancement] display load bytes in show load stmt
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #7134:
URL: https://github.com/apache/incubator-doris/pull/7134#discussion_r755040705
##########
File path: be/src/exec/tablet_sink.cpp
##########
@@ -707,13 +707,15 @@ Status OlapTableSink::open(RuntimeState* state) {
Status OlapTableSink::send(RuntimeState* state, RowBatch* input_batch) {
SCOPED_TIMER(_profile->total_time_counter());
- _number_input_rows += input_batch->num_rows();
// update incrementally so that FE can get the progress.
// the real 'num_rows_load_total' will be set when sink being closed.
- state->update_num_rows_load_total(input_batch->num_rows());
- state->update_num_bytes_load_total(input_batch->total_byte_size());
- DorisMetrics::instance()->load_rows->increment(input_batch->num_rows());
- DorisMetrics::instance()->load_bytes->increment(input_batch->total_byte_size());
+ int64_t num_rows = input_batch->num_rows();
+ int64_t num_bytes = input_batch->total_byte_size();
Review comment:
So I put it into num_bytes avoid call that function twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg merged pull request #7134: [enhancement] display load bytes in show load stmt
Posted by GitBox <gi...@apache.org>.
yangzhg merged pull request #7134:
URL: https://github.com/apache/incubator-doris/pull/7134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #7134: [enhancement] display load bytes in show load stmt
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #7134:
URL: https://github.com/apache/incubator-doris/pull/7134#discussion_r755040230
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/loadv2/BrokerLoadJob.java
##########
@@ -346,6 +346,16 @@ private void updateLoadingStatus(BrokerLoadingTaskAttachment attachment) {
}
}
+ @Override
+ public void updateProgress(Long beId, TUniqueId loadId, TUniqueId fragmentId, long scannedRows,
+ long scannedBytes, boolean isDone) {
+ super.updateProgress(beId, loadId, fragmentId, scannedRows, scannedBytes, isDone);
+ progress = (int) ((double) loadStatistic.getLoadBytes() / loadStatistic.totalFileSizeB * 100);
Review comment:
yes， so I force made the max is 99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org