You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "jiangdongzi (via GitHub)" <gi...@apache.org> on 2023/04/28 08:21:03 UTC

[PR] brpc加redis cluster支持 (brpc)

jiangdongzi opened a new pull request, #2228:
URL: https://github.com/apache/brpc/pull/2228

   ### What problem does this PR solve?
   
   Issue Number:
   
   Problem Summary:
   
   ### What is changed and the side effects?
   
   Changed:
   
   Side effects:
   - Performance effects(性能影响):
   none
   - Breaking backward compatibility(向后兼容性): 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable(请确保你的更改可以通过编译).
   - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
   - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


Re: [PR] brpc加redis cluster支持 (brpc)

Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright commented on PR #2228:
URL: https://github.com/apache/brpc/pull/2228#issuecomment-1528656874

   可以提供一下设计思路和使用方法吗?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


Re: [PR] brpc加redis cluster支持 (brpc)

Posted by "jiangdongzi (via GitHub)" <gi...@apache.org>.
jiangdongzi commented on PR #2228:
URL: https://github.com/apache/brpc/pull/2228#issuecomment-1527182506

   @wwbmmm @chenBright  我自己测试通过了, 实现moved, 和slot路由, 还没实现asking, 可以帮忙提些意见 
   我自己觉得可以改的地方是不需要EMOVED这个错误码, 直接检测到moved错误, 在redis_protocol.cc中直接IssueRpc就行, 但是需要把对应的类设置为Controller的 friend
   实现思路就是实现一个redis_cluster_naming_service 来执行 `CLUSTER SLOTS` 提取对应的信息, 通过tag传给consitent_hashing_load_balancer,  实现一个新的redis_cluster_replica_policy,  hash与slot一一对应.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org