You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/08/20 15:08:20 UTC

[GitHub] [parquet-mr] qinghui-xu opened a new pull request #812: PARQUET-1900: Add mvn clean to CI

qinghui-xu opened a new pull request #812:
URL: https://github.com/apache/parquet-mr/pull/812


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] qinghui-xu commented on pull request #812: PARQUET-1900: Add mvn clean to CI

Posted by GitBox <gi...@apache.org>.
qinghui-xu commented on pull request #812:
URL: https://github.com/apache/parquet-mr/pull/812#issuecomment-679106056


   Hey, yes, I notice that.
   And even adding `mvn clean` seems not triggering the recompile of `parquet-tools`. I've made it [here](https://github.com/qinghui-xu/parquet-mr/tree/newbranch) in my fork for a test purpose and travis did ignore the compilation of it: https://travis-ci.org/github/qinghui-xu/parquet-mr/jobs/719733598
   And by checking the logs, I don't see maven clean plugin being invoked.
   There must be some problems elsewhere.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] Fokko commented on pull request #812: PARQUET-1900: Add mvn clean to CI

Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #812:
URL: https://github.com/apache/parquet-mr/pull/812#issuecomment-713851121


   Thanks @qinghui-xu for following up. Let me know if you find out where the problem lies.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] Fokko closed pull request #812: PARQUET-1900: Add mvn clean to CI

Posted by GitBox <gi...@apache.org>.
Fokko closed pull request #812:
URL: https://github.com/apache/parquet-mr/pull/812


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] Fokko commented on pull request #812: PARQUET-1900: Add mvn clean to CI

Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #812:
URL: https://github.com/apache/parquet-mr/pull/812#issuecomment-678961933


   AFAIK there is no caching from previous runs, so each run should be clean 🤔 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org