You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by jd...@apache.org on 2005/12/06 17:56:06 UTC
svn commit: r354475 -
/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
Author: jdcasey
Date: Tue Dec 6 08:56:02 2005
New Revision: 354475
URL: http://svn.apache.org/viewcvs?rev=354475&view=rev
Log:
Removing prerequisite phase execution: install. Will clean up it2002 in a bit.
Modified:
maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
Modified: maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
URL: http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java?rev=354475&r1=354474&r2=354475&view=diff
==============================================================================
--- maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java (original)
+++ maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java Tue Dec 6 08:56:02 2005
@@ -66,9 +66,6 @@
/**
* Prepare for a release in SCM.
- * <br/>
- * NOTE: This will cause the 'install' phase to be executed...if we cannot
- * at least install the project, we shouldn't start the release process.
*
* @author <a href="mailto:jdcasey@apache.org">John Casey</a>
* @author <a href="mailto:evenisse@apache.org">Emmanuel Venisse</a>
@@ -76,7 +73,6 @@
* @version $Id$
* @aggregator
* @goal prepare
- * @execute phase="install"
* @requiresDependencyResolution test
* @todo check how this works with version ranges
*/
Re: svn commit: r354475 - /maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
Posted by John Casey <jd...@yahoo.com>.
alright, that last round of commits should have taken care of it.
However, see MNG-1766 for the implications of this.
-j
John Casey wrote:
> Dan,
>
> Thanks, but there may yet be another commit related to this stuff, so
> keep an eye out. I'm trying to get it2002 working, which is an involved
> test of this plugin.
>
> -j
>
> dan tran wrote:
>
>> John, you are such an angel.
>>
>> Your work on this fix is fully appreciated.
>>
>> -D
>>
>>
>>
>> On 12/6/05, jdcasey@apache.org <jd...@apache.org> wrote:
>>
>>> Author: jdcasey
>>> Date: Tue Dec 6 08:56:02 2005
>>> New Revision: 354475
>>>
>>> URL: http://svn.apache.org/viewcvs?rev=354475&view=rev
>>> Log:
>>> Removing prerequisite phase execution: install. Will clean up it2002
>>> in a
>>> bit.
>>>
>>> Modified:
>>>
>>> maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
>>>
>>>
>>> Modified:
>>> maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
>>>
>>> URL:
>>> http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java?rev=354475&r1=354474&r2=354475&view=diff
>>>
>>>
>>> ==============================================================================
>>>
>>> ---
>>> maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
>>>
>>> (original)
>>> +++
>>> maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
>>>
>>> Tue Dec 6 08:56:02 2005
>>> @@ -66,9 +66,6 @@
>>>
>>> /**
>>> * Prepare for a release in SCM.
>>> - * <br/>
>>> - * NOTE: This will cause the 'install' phase to be executed...if we
>>> cannot
>>> - * at least install the project, we shouldn't start the release
>>> process.
>>> *
>>> * @author <a href="mailto:jdcasey@apache.org">John Casey</a>
>>> * @author <a href="mailto:evenisse@apache.org">Emmanuel Venisse</a>
>>> @@ -76,7 +73,6 @@
>>> * @version $Id$
>>> * @aggregator
>>> * @goal prepare
>>> - * @execute phase="install"
>>> * @requiresDependencyResolution test
>>> * @todo check how this works with version ranges
>>> */
>>>
>>>
>>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r354475 - /maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
Posted by John Casey <jd...@yahoo.com>.
Dan,
Thanks, but there may yet be another commit related to this stuff, so
keep an eye out. I'm trying to get it2002 working, which is an involved
test of this plugin.
-j
dan tran wrote:
> John, you are such an angel.
>
> Your work on this fix is fully appreciated.
>
> -D
>
>
>
> On 12/6/05, jdcasey@apache.org <jd...@apache.org> wrote:
>
>>Author: jdcasey
>>Date: Tue Dec 6 08:56:02 2005
>>New Revision: 354475
>>
>>URL: http://svn.apache.org/viewcvs?rev=354475&view=rev
>>Log:
>>Removing prerequisite phase execution: install. Will clean up it2002 in a
>>bit.
>>
>>Modified:
>>
>>maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
>>
>>Modified:
>>maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
>>URL:
>>http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java?rev=354475&r1=354474&r2=354475&view=diff
>>
>>==============================================================================
>>---
>>maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
>>(original)
>>+++
>>maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
>>Tue Dec 6 08:56:02 2005
>>@@ -66,9 +66,6 @@
>>
>>/**
>>* Prepare for a release in SCM.
>>- * <br/>
>>- * NOTE: This will cause the 'install' phase to be executed...if we
>>cannot
>>- * at least install the project, we shouldn't start the release process.
>>*
>>* @author <a href="mailto:jdcasey@apache.org">John Casey</a>
>>* @author <a href="mailto:evenisse@apache.org">Emmanuel Venisse</a>
>>@@ -76,7 +73,6 @@
>>* @version $Id$
>>* @aggregator
>>* @goal prepare
>>- * @execute phase="install"
>>* @requiresDependencyResolution test
>>* @todo check how this works with version ranges
>>*/
>>
>>
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r354475 - /maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
Posted by dan tran <da...@gmail.com>.
John, you are such an angel.
Your work on this fix is fully appreciated.
-D
On 12/6/05, jdcasey@apache.org <jd...@apache.org> wrote:
>
> Author: jdcasey
> Date: Tue Dec 6 08:56:02 2005
> New Revision: 354475
>
> URL: http://svn.apache.org/viewcvs?rev=354475&view=rev
> Log:
> Removing prerequisite phase execution: install. Will clean up it2002 in a
> bit.
>
> Modified:
>
> maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
>
> Modified:
> maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
> URL:
> http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java?rev=354475&r1=354474&r2=354475&view=diff
>
> ==============================================================================
> ---
> maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
> (original)
> +++
> maven/plugins/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
> Tue Dec 6 08:56:02 2005
> @@ -66,9 +66,6 @@
>
> /**
> * Prepare for a release in SCM.
> - * <br/>
> - * NOTE: This will cause the 'install' phase to be executed...if we
> cannot
> - * at least install the project, we shouldn't start the release process.
> *
> * @author <a href="mailto:jdcasey@apache.org">John Casey</a>
> * @author <a href="mailto:evenisse@apache.org">Emmanuel Venisse</a>
> @@ -76,7 +73,6 @@
> * @version $Id$
> * @aggregator
> * @goal prepare
> - * @execute phase="install"
> * @requiresDependencyResolution test
> * @todo check how this works with version ranges
> */
>
>
>