[jira] [Comment Edited] (BIGTOP-2295) Docker tests should consume current builds

["Konstantin Boudnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050046#comment-16050046 ] 

Konstantin Boudnik edited comment on BIGTOP-2295 at 6/15/17 6:21 AM:
---------------------------------------------------------------------

Hmm, something weird is going on. I am looking into the configuration of [Bigtop-trunk-deployment|https://ci.bigtop.apache.org/view/Provisioner/job/Bigtop-trunk-deployments/] job and I see the following code among the build steps:
{code}
if [ ${OS} == "centos6" ] || [ ${OS} == "centos7" ] || [ ${OS} == "fedora25" ]; then
  echo "Using repo from https://ci.bigtop.apache.org/view/Packages/job/Bigtop-trunk-packages/COMPONENTS=${COMPONENTS},OS=${OS}/lastSuccessfulBuild/artifact/output"
  sed "s/repo.*/repo: https:\/\/ci.bigtop.apache.org\/view\/Packages\/job\/Bigtop-trunk-packages\/COMPONENTS=${COMPONENTS},OS=${OS}\/lastSuccessfulBuild\/artifact\/output/g" \
    provisioner/docker/${CONFIG} > provisioner/docker/${CONFIG}
else
  echo "Using repo from https://ci.bigtop.apache.org/view/Packages/job/Bigtop-trunk-packages/COMPONENTS=${COMPONENTS},OS=${OS}/lastSuccessfulBuild/artifact/output/apt"
  sed "s/repo.*/repo: https:\/\/ci.bigtop.apache.org\/view\/Packages\/job\/Bigtop-trunk-packages\/COMPONENTS=${COMPONENTS},OS=${OS}\/lastSuccessfulBuild\/artifact\/output\/apt/g" \
    provisioner/docker/${CONFIG} > provisioner/docker/${CONFIG}
fi
{code}
which indicates that we *suppose* to use the nightly packages. However, the code code is buggy because the OS names in this job configuration aren't matching OS names in the package build. E.g. {{centos6}} vs {{centos-6}}; {{ubuntu-xenial}} vs {{ubuntu-16.04}} and so on. As the result of the sed operation failure, we are using the whatever is set in the provisioner's configuration files.

As I see it, we have two ways of fixing it:
# rename the provisioner's configs to use the same OS names as our CI matrices are using (centos-7, debian-8, ubuntu-16.04)
# fix the provisioner job to use the correct names in the repo URLs
I really prefer the former fix, because it is more consistent, but i might break something else, possible in some user setup. I am not very concerned about that part, but it something to keep in mind.

Thoughts?


was (Author: cos):
Hmm, something weird is going on. I am looking into the configuration of [Bigtop-trunk-deployment|https://ci.bigtop.apache.org/view/Provisioner/job/Bigtop-trunk-deployments/] job and I see the following code among the build steps:
{code}
if [ ${OS} == "centos6" ] || [ ${OS} == "centos7" ] || [ ${OS} == "fedora25" ]; then
  echo "Using repo from https://ci.bigtop.apache.org/view/Packages/job/Bigtop-trunk-packages/COMPONENTS=${COMPONENTS},OS=${OS}/lastSuccessfulBuild/artifact/output"
  sed "s/repo.*/repo: https:\/\/ci.bigtop.apache.org\/view\/Packages\/job\/Bigtop-trunk-packages\/COMPONENTS=${COMPONENTS},OS=${OS}\/lastSuccessfulBuild\/artifact\/output/g" \
    provisioner/docker/${CONFIG} > provisioner/docker/${CONFIG}
else
  echo "Using repo from https://ci.bigtop.apache.org/view/Packages/job/Bigtop-trunk-packages/COMPONENTS=${COMPONENTS},OS=${OS}/lastSuccessfulBuild/artifact/output/apt"
  sed "s/repo.*/repo: https:\/\/ci.bigtop.apache.org\/view\/Packages\/job\/Bigtop-trunk-packages\/COMPONENTS=${COMPONENTS},OS=${OS}\/lastSuccessfulBuild\/artifact\/output\/apt/g" \
    provisioner/docker/${CONFIG} > provisioner/docker/${CONFIG}
fi
{code}
which indicates that we *suppose* to use the nightly packages. However, the code code is buggy because the OS names in this job configuration aren't matching OS names in the package build. E.g. {{centos6}} vs {{centos-6}}; {{ubuntu-xenial}} vs {{ubuntu-16.04}} and so on. As the result of the sed operation failure, we are using the whatever is set in the configuration files.

> Docker tests should consume current builds
> ------------------------------------------
>
>                 Key: BIGTOP-2295
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2295
>             Project: Bigtop
>          Issue Type: Bug
>          Components: build, ci
>            Reporter: Olaf Flebbe
>            Assignee: Olaf Flebbe
>             Fix For: 1.3.0
>
>         Attachments: BIGTOP-2295.1.patch
>
>
> Die Download URL of packages point to 1.0 bigtop builds. They should point to a current stable build. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)