You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by José Armando García Sancio <js...@confluent.io.INVALID> on 2022/12/20 19:29:30 UTC

[DISCUSS] Suppressing style checks

Hi all,

I added the following modules to the code style checker:
https://github.com/apache/kafka/blob/44b3177a087ff809a9d95a27b63b10e00aa4da7d/checkstyle/checkstyle.xml#L147-L156

I think this feature has a few benefits.
1) It should allow us to move style check suppressions to the code
using the @SuppressWarnings annotation. Here is an example:
https://github.com/apache/kafka/blob/44b3177a087ff809a9d95a27b63b10e00aa4da7d/metadata/src/main/java/org/apache/kafka/controller/ControllerMetricsManager.java#L110

2) Have more targeted warning suppression instead of suppressing
coding style for the entire file.

3) Incrementally remove some of the clutter from the
checkstyle/suppressions.xml file.

Thanks!
-- 
-José