You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2015/07/01 17:28:22 UTC

svn commit: r1688670 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckbox.java

Author: msahyoun
Date: Wed Jul  1 15:28:22 2015
New Revision: 1688670

URL: http://svn.apache.org/r1688670
Log:
PDFBOX-2849: use new COSName.Off

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckbox.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckbox.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckbox.java?rev=1688670&r1=1688669&r2=1688670&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckbox.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDCheckbox.java Wed Jul  1 15:28:22 2015
@@ -173,10 +173,7 @@ public final class PDCheckbox extends PD
                 Set<COSName> entries = normalAppearance.getSubDictionary().keySet();
                 for (COSName entry : entries)
                 {
-                    // Specifically looking for the string 'Off' as the off value
-                    // Can't use COSName.OFF here as this will be 'OFF' in uppercase
-                    // but for form fields the correct value is 'Off' in mixed case
-                    if ("Off".compareTo(entry.getName()) != 0)
+                    if (COSName.Off.compareTo(entry) != 0)
                     {
                         onValue = entry.getName();
                     }