You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/08/10 18:43:24 UTC

Review Request 37302: Delete receive,install

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37302/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos


Description
-------

Delete receive handlers ,install call back setups


Diffs
-----

  src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 

Diff: https://reviews.apache.org/r/37302/diff/


Testing
-------


Thanks,

Anand Mazumdar


Re: Review Request 37302: Delete receive,install

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37302/#review94867
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Aug. 11, 2015, 3:24 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37302/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 3:24 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Delete receive handlers ,install call back setups. Helps ease of review in diff for r37303
> 
> 
> Diffs
> -----
> 
>   src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 
> 
> Diff: https://reviews.apache.org/r/37302/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Re: Review Request 37302: Deleted old style message handling from the scheduler library.

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37302/
-----------------------------------------------------------

(Updated Aug. 11, 2015, 5:58 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

updated summary -- @vinodkone.


Summary (updated)
-----------------

Deleted old style message handling from the scheduler library.


Repository: mesos


Description
-------

Delete receive handlers ,install call back setups. Helps ease of review in diff for r37303


Diffs
-----

  src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 

Diff: https://reviews.apache.org/r/37302/diff/


Testing
-------


Thanks,

Anand Mazumdar


Re: Review Request 37302: Delete receive,install

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37302/
-----------------------------------------------------------

(Updated Aug. 11, 2015, 5:53 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

Update depends-on


Repository: mesos


Description
-------

Delete receive handlers ,install call back setups. Helps ease of review in diff for r37303


Diffs
-----

  src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 

Diff: https://reviews.apache.org/r/37302/diff/


Testing
-------


Thanks,

Anand Mazumdar


Re: Review Request 37302: Delete receive,install

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37302/
-----------------------------------------------------------

(Updated Aug. 11, 2015, 3:24 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

Modify deps


Repository: mesos


Description (updated)
-------

Delete receive handlers ,install call back setups. Helps ease of review in diff for r37303


Diffs
-----

  src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 

Diff: https://reviews.apache.org/r/37302/diff/


Testing
-------


Thanks,

Anand Mazumdar


Re: Review Request 37302: Delete receive,install

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37302/
-----------------------------------------------------------

(Updated Aug. 11, 2015, 12:17 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

Removed receive function. For context see r37303


Repository: mesos


Description
-------

Delete receive handlers ,install call back setups


Diffs (updated)
-----

  src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 

Diff: https://reviews.apache.org/r/37302/diff/


Testing
-------


Thanks,

Anand Mazumdar


Re: Review Request 37302: Delete receive,install

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37302/
-----------------------------------------------------------

(Updated Aug. 10, 2015, 6:47 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos


Description
-------

Delete receive handlers ,install call back setups


Diffs
-----

  src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 

Diff: https://reviews.apache.org/r/37302/diff/


Testing
-------


Thanks,

Anand Mazumdar


Re: Review Request 37302: Delete receive,install

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37302/
-----------------------------------------------------------

(Updated Aug. 10, 2015, 6:46 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

Modify depends on to swap order


Repository: mesos


Description
-------

Delete receive handlers ,install call back setups


Diffs
-----

  src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 

Diff: https://reviews.apache.org/r/37302/diff/


Testing
-------


Thanks,

Anand Mazumdar


Re: Review Request 37302: Delete receive,install

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37302/
-----------------------------------------------------------

(Updated Aug. 10, 2015, 4:45 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

Depends on change


Repository: mesos


Description
-------

Delete receive handlers ,install call back setups


Diffs
-----

  src/scheduler/scheduler.cpp a8699a7514892a548eb03f9dcb6a1198ce518830 

Diff: https://reviews.apache.org/r/37302/diff/


Testing
-------


Thanks,

Anand Mazumdar