[GitHub] [ignite] NSAmelchev commented on a change in pull request #8317: IGNITE-13520 Skip generating encryption keys on the client node.

[GitBox <gi...@apache.org>]

NSAmelchev commented on a change in pull request #8317:
URL: https://github.com/apache/ignite/pull/8317#discussion_r501682068



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/ClusterCachesInfo.java
##########
@@ -2003,6 +2003,12 @@ private String processJoiningNode(CacheJoinNodeDiscoveryData joinData, UUID node
             if (!registeredCaches.containsKey(cfg.getName())) {
                 String conflictErr = checkCacheConflict(cfg);
 
+                if (conflictErr == null && cfg.isEncryptionEnabled() && !locJoin &&
+                    ctx.encryption().groupKey(CU.cacheGroupId(cfg.getName(), cfg.getGroupName())) == null) {
+                    conflictErr = "Encryption key has not been generated. " +
+                        "The client node must dynamically start this cache [cacheName=" + cfg.getName() + "]";

Review comment:
       I think we should to write that cache *will be* started dynamically 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org